From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
quic_mkrishn@quicinc.com, linux-arm-msm@vger.kernel.org
Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations
Date: Tue, 8 Nov 2022 16:00:28 +0300 [thread overview]
Message-ID: <eb36741a-6e07-402e-b707-0eb0708f6b9d@linaro.org> (raw)
In-Reply-To: <20221107235654.1769462-5-bryan.odonoghue@linaro.org>
On 08/11/2022 02:56, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml dt-binding descriptions we appear to
> have missed some of the previous detail on the number and names of
> permissible clocks.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
However it might be easier to move this patch after the patch adding the
per-platform compat strings. Then you can push these items into the
clauses where they are required.
> ---
> .../bindings/display/msm/dsi-controller-main.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 0f7747e55b9be..cab38a20a54b0 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -35,6 +35,10 @@ properties:
> - description: Display escape clock
> - description: Display AHB clock
> - description: Display AXI clock
> + - description: Core MultiMedia SubSystem clock
> + - description: MDP Core clock
> + - description: MNOC clock
> + minItems: 6
>
> clock-names:
> items:
> @@ -44,6 +48,10 @@ properties:
> - const: core
> - const: iface
> - const: bus
> + - const: core_mmss
> + - const: mdp_core
> + - const: mnoc
> + minItems: 6
>
> phys:
> maxItems: 1
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-11-08 13:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221107235654.1769462-1-bryan.odonoghue@linaro.org>
2022-11-07 23:56 ` [PATCH v2 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-11-08 21:10 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-11-08 12:59 ` Dmitry Baryshkov
2022-11-08 14:42 ` Bryan O'Donoghue
2022-11-08 16:55 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 04/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-11-08 13:00 ` Dmitry Baryshkov [this message]
2022-11-07 23:56 ` [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-11-08 13:01 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum Bryan O'Donoghue
2022-11-08 21:13 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-11-08 12:46 ` Dmitry Baryshkov
2022-11-08 21:15 ` Krzysztof Kozlowski
2022-11-18 13:29 ` Bryan O'Donoghue
2022-11-18 13:30 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-11-08 12:43 ` Dmitry Baryshkov
2022-11-08 12:45 ` Bryan O'Donoghue
2022-11-08 21:19 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 09/18] ARM: dts: qcom: apq8064: add compat qcom,mdss-dsi-ctrl-apq8064 Bryan O'Donoghue
2022-11-08 13:22 ` David Heidelberg
2022-11-07 23:56 ` [PATCH v2 10/18] ARM: dts: qcom: msm8974: Add compat qcom,mdss-dsi-ctrl-msm8974 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 11/18] arm64: dts: qcom: msm8916: Add compat qcom,mdss-dsi-ctrl-msm8916 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 12/18] arm64: dts: qcom: msm8996: Add compat qcom,mdss-dsi-ctrl-msm8996 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 13/18] arm64: dts: qcom: sc7180: Add compat qcom,mdss-dsi-ctrl-sc7180 Bryan O'Donoghue
2022-11-08 0:24 ` Doug Anderson
2022-11-08 12:16 ` Bryan O'Donoghue
2022-11-08 16:41 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 14/18] arm64: dts: qcom: sc7280: Add compat qcom,mdss-dsi-ctrl-sc7280 Bryan O'Donoghue
2022-11-08 16:41 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 15/18] arm64: dts: qcom: sdm630: Add compat qcom,mdss-dsi-ctrl-sdm630 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 16/18] arm64: dts: qcom: sdm660: Add compat qcom,mdss-dsi-ctrl-sdm660 Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 17/18] arm64: dts: qcom: sdm845: Add compat qcom,mdss-dsi-ctrl-sdm845 Bryan O'Donoghue
2022-11-08 16:42 ` Doug Anderson
2022-11-07 23:56 ` [PATCH v2 18/18] arm64: dts: qcom: sm8250: Add compat qcom,mdss-dsi-ctrl-sm8250 Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb36741a-6e07-402e-b707-0eb0708f6b9d@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).