linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
	bpf@vger.kernel.org
Subject: Re: [PATCH] tools build feature: cleanup feature files on make clean
Date: Thu, 3 Sep 2020 21:20:35 +0200	[thread overview]
Message-ID: <eb3ad60a-68be-f350-9597-b999edae5244@iogearbox.net> (raw)
In-Reply-To: <20200903190350.GI3495158@kernel.org>

Hi Arnaldo,

On 9/3/20 9:03 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 27, 2020 at 10:53:36AM +0200, Jesper Dangaard Brouer escreveu:
>> The system for "Auto-detecting system features" located under
>> tools/build/ are (currently) used by perf, libbpf and bpftool. It can
>> contain stalled feature detection files, which are not cleaned up by
>> libbpf and bpftool on make clean (side-note: perf tool is correct).
>>
>> Fix this by making the users invoke the make clean target.
>>
>> Some details about the changes. The libbpf Makefile already had a
>> clean-config target (which seems to be copy-pasted from perf), but this
>> target was not "connected" (a make dependency) to clean target. Choose
>> not to rename target as someone might be using it. Did change the output
>> from "CLEAN config" to "CLEAN feature-detect", to make it more clear
>> what happens.
> 
> Since this mostly touches BPF, should it go via the BPF tree?

Already applied roughly a week ago:

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=661b37cd437ef49cd28444f79b9b0c71ea76e8c8

Thanks,
Daniel

  reply	other threads:[~2020-09-03 19:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  8:53 [PATCH] tools build feature: cleanup feature files on make clean Jesper Dangaard Brouer
2020-08-27 12:44 ` Jiri Olsa
2020-08-28 12:14 ` Daniel Borkmann
2020-09-03 19:03 ` Arnaldo Carvalho de Melo
2020-09-03 19:20   ` Daniel Borkmann [this message]
2020-09-03 19:26     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb3ad60a-68be-f350-9597-b999edae5244@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=acme@kernel.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).