From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbcFUVtA (ORCPT ); Tue, 21 Jun 2016 17:49:00 -0400 Received: from mx1.imag.fr ([129.88.30.5]:33800 "EHLO mx1.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbcFUVsc (ORCPT ); Tue, 21 Jun 2016 17:48:32 -0400 Subject: Re: [PATCH v3 6/8] coccicheck: add support for requring a coccinelle version To: "Luis R. Rodriguez" , Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, mmarek@suse.com References: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> <1466536893-23355-7-git-send-email-mcgrof@kernel.org> Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, markivx@codeaurora.org, stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com, broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, deepa.kernel@gmail.com, cocci@systeme.lip6.fr From: "Nicolas Palix (LIG)" Organization: UJF Polytech / LIG Erods Message-ID: Date: Tue, 21 Jun 2016 23:11:39 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466536893-23355-7-git-send-email-mcgrof@kernel.org> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms080803010203070807060109" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (mx1.imag.fr [129.88.30.5]); Tue, 21 Jun 2016 23:11:40 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: u5LLBdGT023773 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: nicolas.palix@imag.fr MailScanner-NULL-Check: 1467148300.71922@WCwTe3yEcrenSKmBZOraYQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms080803010203070807060109 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Le 21/06/16 =E0 21:21, Luis R. Rodriguez a =E9crit : > Enable Coccinelle SmPL patches to require a specific version of > Coccinelle. In the event that the version does not match we just > inform the user, if the user asked to go through all SmPL patches > we just inform them of the need for a new version of coccinelle for > the SmPL patch and continue on with the rest. > > This uses the simple kernel scripts/ld-version.sh to create a weight > on the version provided by spatch. The -dirty attribute is ignored if > supplied, the benefit of scripts/ld-version.sh is it has a long history= > and well tested. > > Signed-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix > --- > scripts/coccicheck | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index 998d764636e0..01b6716ea931 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -5,6 +5,7 @@ > # version 1.0.0-rc11. > # > > +DIR=3D"$(dirname $(readlink -f $0))/.." > SPATCH=3D"`which ${SPATCH:=3Dspatch}`" > > if [ ! -x "$SPATCH" ]; then > @@ -12,6 +13,9 @@ if [ ! -x "$SPATCH" ]; then > exit 1 > fi > > +SPATCH_VERSION=3D$($SPATCH --version | head -1 | awk '{print $3}') > +SPATCH_VERSION_NUM=3D$(echo $SPATCH_VERSION | ${DIR}/scripts/ld-versio= n.sh) > + > USE_JOBS=3D"no" > $SPATCH --help | grep "\-\-jobs" > /dev/null && USE_JOBS=3D"yes" > > @@ -171,6 +175,16 @@ coccinelle () { > COCCI=3D"$1" > > OPT=3D`grep "Option" $COCCI | cut -d':' -f2` > + REQ=3D`grep "Requires" $COCCI | cut -d':' -f2 | sed "s| ||"` > + REQ_NUM=3D$(echo $REQ | ${DIR}/scripts/ld-version.sh) > + if [ "$REQ_NUM" !=3D "0" ] ; then > + if [ "$SPATCH_VERSION_NUM" -lt "$REQ_NUM" ] ; then > + echo "Skipping coccinele SmPL patch: $COCCI" > + echo "You have coccinelle: $SPATCH_VERSION" > + echo "This SmPL patch requires: $REQ" > + return > + fi > + fi > > # The option '--parse-cocci' can be used to syntactically check the = SmPL files. > # > --=20 Nicolas Palix http://lig-membres.imag.fr/palix/ --------------ms080803010203070807060109 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: Signature cryptographique S/MIME MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC CG8wggO2MIICnqADAgECAgEDMA0GCSqGSIb3DQEBBQUAMCwxCzAJBgNVBAYTAkZSMQ0wCwYD VQQKEwRDTlJTMQ4wDAYDVQQDEwVDTlJTMjAeFw0wOTAxMjEwOTAzNTJaFw0yOTAxMjAwOTAz NTJaMDUxCzAJBgNVBAYTAkZSMQ0wCwYDVQQKEwRDTlJTMRcwFQYDVQQDEw5DTlJTMi1TdGFu ZGFyZDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAJypZGq0ByMZw74ICMTiKl3t 1Cje/j+g7ZJEaxZHNRM3jXSp9U2D5AUbjwhhTN53W9ep/7tlncmsPA/xiXuTIqBHD18Gvo54 oAt510JlYXJjkkCKW2cQ+tYnPth3TR55229LEgBSWOLYQgWyMzd34I1sHbz49vKUWCX3gtmG 2Vzz2C7N/XCJBIfvOdEq2JKMaS8cUmX6YI8Qf8yP+VwuFO1Mi+CdN7jSPJTKUP1Bet72POyu 7L1cFt2w8HOZeoH/OzPSAJ5NjMZbOC4zw3aGynJU2y3iEP2SUGiThO13qYlpUYXr4JSj+ZcI EYwk8A+6OLQs1tdsTmP+tDGf74+mWqUCAwEAAaOB2TCB1jAPBgNVHRMBAf8EBTADAQH/MB0G A1UdDgQWBBQR49nRUkcbWbE8G3hma/ShiO0KWzBUBgNVHSMETTBLgBRQl7YN96wzF6/xHUY8 azv/AKDl5aEwpC4wLDELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxDjAMBgNVBAMTBUNO UlMyggEAMA4GA1UdDwEB/wQEAwIBBjA+BgNVHR8ENzA1MDOgMaAvhi1odHRwOi8vY3Jscy5z ZXJ2aWNlcy5jbnJzLmZyL0NOUlMyL2dldGRlci5jcmwwDQYJKoZIhvcNAQEFBQADggEBAE/p 4xfmTCf1F2pQVeruz0yqve4s3XY+WaAvC2iJ2kPQHh0saxL5ZxOeZSukhNIxz4Kgyu8i6BBs 6c8XfKyth4VMiuHVe0zm2Q6yoeQpniCvDz57uX8kTDLgiP562qwWYKF1romcimadlLp+qw4g I+33x4RdgkgU3sTUsMVOLIfUjQMRLzbVKW+umWcZDI1tWiDf0Z/Gy69V7gvKsVsP71x09PNG iWNHfizOv8gwDQBG9hjmbD8wfpBuEI0fOUnPk2nryJ7CZ3OvSov2fEIo3aXd7a/JVRtkP1S8 YSYQ65HV6ffu0PYLC/qmkN1g9ECdC6ec+M4vITj+qwa/2g13+mcwggSxMIIDmaADAgECAgMA sYYwDQYJKoZIhvcNAQEFBQAwNTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNV BAMTDkNOUlMyLVN0YW5kYXJkMB4XDTE2MDMzMTE0MzczN1oXDTE4MDMzMTE0MzczN1owbDEL MAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxEDAOBgNVBAsTB1VNUjUyMTcxFjAUBgNVBAMT DU5pY29sYXMgUGFsaXgxJDAiBgkqhkiG9w0BCQEWFU5pY29sYXMuUGFsaXhAaW1hZy5mcjCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOrXeKVCpb7MjlNJjUttPdthNS7GvU/h TZezIPCzuM73eHIpYNVx0qVsnP6fTzAc+7i7a/hAcTM2XChLkm+tzpbWJ44CNoQ9+OCgMW+3 6sRS1Kv66bz1qKqxj4hXnWoGga/ND4bbMmtS0tG+LZ0jpqk5p2K01DU12XnmQ5zi5O+eV0i1 ERLJkJd+m9duJOCa9tni/b05Lcs2LClfYFrmr1cMvGPmy0UguRYrlWjQrMKddLLmMgo8cv4n GebpUfcgo3WmOz4BxKjNzj551Quy2QVtg3gYvuUEtNW88ONofmJ3+wr++ialKRPZM0C1MaCN c6HJ//GVMWldxs0dQLrqUs8CAwEAAaOCAZEwggGNMAwGA1UdEwEB/wQCMAAwEQYJYIZIAYb4 QgEBBAQDAgSwMA4GA1UdDwEB/wQEAwIF4DB6BglghkgBhvhCAQ0EbRZrQ2VydGlmaWNhdCBD TlJTMi1TdGFuZGFyZC4gUG91ciB0b3V0ZSBpbmZvcm1hdGlvbiBzZSByZXBvcnRlciDgIGh0 dHA6Ly9pZ2Muc2VydmljZXMuY25ycy5mci9DTlJTMi1TdGFuZGFyZC8wHQYDVR0OBBYEFLd6 +Ifph9Z/6Ky//jQzMhNtCru7MFQGA1UdIwRNMEuAFBHj2dFSRxtZsTwbeGZr9KGI7QpboTCk LjAsMQswCQYDVQQGEwJGUjENMAsGA1UEChMEQ05SUzEOMAwGA1UEAxMFQ05SUzKCAQMwIAYD VR0RBBkwF4EVTmljb2xhcy5QYWxpeEBpbWFnLmZyMEcGA1UdHwRAMD4wPKA6oDiGNmh0dHA6 Ly9jcmxzLnNlcnZpY2VzLmNucnMuZnIvQ05SUzItU3RhbmRhcmQvZ2V0ZGVyLmNybDANBgkq hkiG9w0BAQUFAAOCAQEAhowl+iLEKBtHY1ygh+luUrBwA/a0PnqnR4Ih92ywgJZ+8yawSpuw p3pqgXAi0WVqWN5fIYZII954W4XwUAedKxdBvOqLXfI1XwwnkhZ09icVWPJX0JZUBfVtKE9x 7sYtD5sknfFNX8dOoy88B1USDVw9BCoOdFr6fMOB+hmneZ/v+Wdj2RTir3IY6xDocwTAfJ4n DdngikVPugfoUyNWR04J1bD9AVj2tNsZIu5cMgsj6ZISpRYHstB7LBx9Ya1zScctTGAT2fup DiiEzqGjJcUSZUMuuvJmIR6v4toqr03yxR90yCn0eiLJOXtHGqOogAaXIGGDHGMS6KIU2hM8 CTGCAt4wggLaAgEBMDwwNTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNVBAMT DkNOUlMyLVN0YW5kYXJkAgMAsYYwDQYJYIZIAWUDBAIBBQCgggFzMBgGCSqGSIb3DQEJAzEL BgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE2MDYyMTIxMTEzOVowLwYJKoZIhvcNAQkE MSIEIL8Wtr7WetS8/OZjioUNVlPDQ6sDqtq213ST2bdQUFTNMEsGCSsGAQQBgjcQBDE+MDww NTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNVBAMTDkNOUlMyLVN0YW5kYXJk AgMAsYYwTQYLKoZIhvcNAQkQAgsxPqA8MDUxCzAJBgNVBAYTAkZSMQ0wCwYDVQQKEwRDTlJT MRcwFQYDVQQDEw5DTlJTMi1TdGFuZGFyZAIDALGGMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZI AWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZI hvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAEggEAReii BGNhAF+4U0Ot8Yc2qcrr7eZIqW/b24+SR9xb9rayxq+kRbmpgRqzAHuXJ1/CVfpfg1rFseFM YgFiTBwaSxggXwFq7+a4EdHbkcbv6PWqNu2Bed+V1rf5SnlDvW/+8EvRBHvTaegS37tWhLEg JYOdZ/useEAQJaKUDzXXnYZt65zofpyDmuCUPbe9klfw61i9/mT/eaKtjuem1txZduhKdWpE iNOX8DJ0Stz6oJnYd970gRMv0bRoCDZad0R2+1XO1DYq9GHVJka1cDIxD8tU1GU44aDzslYi Wt65FY4akxD7dpllAKrC93PPOb+Z9Zs5kSCJ8LUjcwMFJVT9XgAAAAAAAA== --------------ms080803010203070807060109--