From: "Paraschiv, Andra-Irina" <andraprs@amazon.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
David Duncan <davdunc@amazon.com>,
Dexuan Cui <decui@microsoft.com>, Alexander Graf <graf@amazon.de>,
Jorgen Hansen <jhansen@vmware.com>,
Jakub Kicinski <kuba@kernel.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH net-next v2 0/4] vsock: Add flags field in the vsock address
Date: Mon, 7 Dec 2020 21:18:02 +0200 [thread overview]
Message-ID: <eb53647a-dbf4-ace4-3cf8-a55c1fbb0c7a@amazon.com> (raw)
In-Reply-To: <20201207100525.v4z7rlewnwubjphu@steredhat>
On 07/12/2020 12:05, Stefano Garzarella wrote:
>
> Hi Andra,
>
> On Fri, Dec 04, 2020 at 07:02:31PM +0200, Andra Paraschiv wrote:
>> vsock enables communication between virtual machines and the host
>> they are
>> running on. Nested VMs can be setup to use vsock channels, as the multi
>> transport support has been available in the mainline since the v5.5
>> Linux kernel
>> has been released.
>>
>> Implicitly, if no host->guest vsock transport is loaded, all the
>> vsock packets
>> are forwarded to the host. This behavior can be used to setup
>> communication
>> channels between sibling VMs that are running on the same host. One
>> example can
>> be the vsock channels that can be established within AWS Nitro Enclaves
>> (see Documentation/virt/ne_overview.rst).
>>
>> To be able to explicitly mark a connection as being used for a
>> certain use case,
>> add a flags field in the vsock address data structure. The
>> "svm_reserved1" field
>> has been repurposed to be the flags field. The value of the flags
>> will then be
>> taken into consideration when the vsock transport is assigned. This
>> way can
>> distinguish between different use cases, such as nested VMs / local
>> communication
>> and sibling VMs.
>
> the series seems in a good shape, I left some minor comments.
> I run my test suite (vsock_test, iperf3, nc) with nested VMs (QEMU/KVM),
> and everything looks good.
Thanks, Stefano, for review and checking it out for the nested case as well.
I'll send out v3 including the addressed feedback and the Rb tags.
>
> Note: I'll be offline today and tomorrow, so I may miss followups.
Ok, np, thanks for the heads-up.
Andra
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
prev parent reply other threads:[~2020-12-07 19:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 17:02 Andra Paraschiv
2020-12-04 17:02 ` [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure Andra Paraschiv
2020-12-07 9:59 ` Stefano Garzarella
2020-12-07 19:25 ` Paraschiv, Andra-Irina
2020-12-07 21:29 ` Jakub Kicinski
2020-12-08 18:23 ` Paraschiv, Andra-Irina
2020-12-08 18:42 ` Jakub Kicinski
2020-12-09 10:48 ` Stefano Garzarella
2020-12-09 15:17 ` Paraschiv, Andra-Irina
2020-12-09 17:30 ` Jakub Kicinski
2020-12-10 15:29 ` Paraschiv, Andra-Irina
2020-12-04 17:02 ` [PATCH net-next v2 2/4] vm_sockets: Add VMADDR_FLAG_TO_HOST vsock flag Andra Paraschiv
2020-12-07 9:59 ` Stefano Garzarella
2020-12-07 19:45 ` Paraschiv, Andra-Irina
2020-12-04 17:02 ` [PATCH net-next v2 3/4] af_vsock: Set VMADDR_FLAG_TO_HOST flag on the receive path Andra Paraschiv
2020-12-07 9:59 ` Stefano Garzarella
2020-12-04 17:02 ` [PATCH net-next v2 4/4] af_vsock: Assign the vsock transport considering the vsock address flags Andra Paraschiv
2020-12-07 10:00 ` Stefano Garzarella
2020-12-07 19:51 ` Paraschiv, Andra-Irina
2020-12-07 10:05 ` [PATCH net-next v2 0/4] vsock: Add flags field in the vsock address Stefano Garzarella
2020-12-07 19:18 ` Paraschiv, Andra-Irina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb53647a-dbf4-ace4-3cf8-a55c1fbb0c7a@amazon.com \
--to=andraprs@amazon.com \
--cc=davdunc@amazon.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=graf@amazon.de \
--cc=jhansen@vmware.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=vkuznets@redhat.com \
--subject='Re: [PATCH net-next v2 0/4] vsock: Add flags field in the vsock address' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).