From: Jes Sorensen <jes.sorensen@gmail.com>
To: samirweng1979 <samirweng1979@163.com>,
kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
wengjianfeng <wengjianfeng@yulong.com>
Subject: Re: [PATCH] rtl8xxxu: remove unnecessary labels
Date: Wed, 21 Jul 2021 09:37:07 -0400 [thread overview]
Message-ID: <eb5393c9-77d5-37f1-e9e8-67795958c9e6@gmail.com> (raw)
In-Reply-To: <20210720070040.20840-1-samirweng1979@163.com>
On 7/20/21 3:00 AM, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> Simplify the code by removing unnecessary labels and returning directly.
>
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723a.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
NACK
Using gotos to have a unified exit path keeps the code cleaner and makes
it easier to ensure locking is correct where applicable.
Jes
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723a.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723a.c
> index 4f93f88..3fd14e6 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723a.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723a.c
> @@ -256,10 +256,8 @@ static int rtl8723a_emu_to_active(struct rtl8xxxu_priv *priv)
> udelay(10);
> }
>
> - if (!count) {
> - ret = -EBUSY;
> - goto exit;
> - }
> + if (!count)
> + return -EBUSY;
>
> /* We should be able to optimize the following three entries into one */
>
> @@ -292,10 +290,8 @@ static int rtl8723a_emu_to_active(struct rtl8xxxu_priv *priv)
> udelay(10);
> }
>
> - if (!count) {
> - ret = -EBUSY;
> - goto exit;
> - }
> + if (!count)
> + return3RGD9F -EBUSY;
>
> /* 0x4C[23] = 0x4E[7] = 1, switch DPDT_SEL_P output from WL BB */
> /*
> @@ -307,7 +303,6 @@ static int rtl8723a_emu_to_active(struct rtl8xxxu_priv *priv)
> val8 &= ~LEDCFG2_DPDT_SELECT;
> rtl8xxxu_write8(priv, REG_LEDCFG2, val8);
>
> -exit:
> return ret;
> }
>
> @@ -327,7 +322,7 @@ static int rtl8723au_power_on(struct rtl8xxxu_priv *priv)
>
> ret = rtl8723a_emu_to_active(priv);
> if (ret)
> - goto exit;
> + return ret;
>
> /*
> * 0x0004[19] = 1, reset 8051
> @@ -353,7 +348,7 @@ static int rtl8723au_power_on(struct rtl8xxxu_priv *priv)
> val32 &= ~(BIT(28) | BIT(29) | BIT(30));
> val32 |= (0x06 << 28);
> rtl8xxxu_write32(priv, REG_EFUSE_CTRL, val32);
> -exit:
> +
> return ret;
> }
>
>
prev parent reply other threads:[~2021-07-21 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 7:00 [PATCH] rtl8xxxu: remove unnecessary labels samirweng1979
2021-07-21 13:37 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5393c9-77d5-37f1-e9e8-67795958c9e6@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samirweng1979@163.com \
--cc=wengjianfeng@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).