From: Johan Jonker <jbx6244@gmail.com>
To: Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>, Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support
Date: Wed, 28 Jul 2021 18:45:45 +0200 [thread overview]
Message-ID: <eb5932de-bd6c-de5e-d130-5252f98a12c7@gmail.com> (raw)
In-Reply-To: <20210728161020.3905-3-michael.riesch@wolfvision.net>
Hi Michael,
On 7/28/21 6:10 PM, Michael Riesch wrote:
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
> .../boot/dts/rockchip/rk3568-evb1-v10.dts | 69 +++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> index 69786557093d..8f4c40d71914 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> @@ -13,6 +13,11 @@
> model = "Rockchip RK3568 EVB1 DDR4 V10 Board";
> compatible = "rockchip,rk3568-evb1-v10", "rockchip,rk3568";
>
> + aliases {
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + };
> +
> chosen: chosen {
> stdout-path = "serial2:1500000n8";
> };
> @@ -67,6 +72,70 @@
> };
> };
>
> +&gmac0 {
> + phy-mode = "rgmii";
> + clock_in_out = "output";
> +
> + assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
> + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
> + assigned-clock-rates = <0>, <125000000>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac0_miim
> + &gmac0_tx_bus2
> + &gmac0_rx_bus2
> + &gmac0_rgmii_clk
> + &gmac0_rgmii_bus>;
> +
> + tx_delay = <0x3c>;
> + rx_delay = <0x2f>;
> +
> + phy-handle = <&rgmii_phy0>;
> + status = "okay";
> +};
> +
> +&gmac1 {
> + phy-mode = "rgmii";
> + clock_in_out = "output";
> +
> + assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
> + assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>;
> + assigned-clock-rates = <0>, <125000000>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac1m1_miim
> + &gmac1m1_tx_bus2
> + &gmac1m1_rx_bus2
> + &gmac1m1_rgmii_clk
> + &gmac1m1_rgmii_bus>;
> +
> + tx_delay = <0x4f>;
> + rx_delay = <0x26>;
> +
> + phy-handle = <&rgmii_phy1>;
> + status = "okay";
> +};
> +
> +&mdio0 {
> + rgmii_phy0: phy@0 {
Could you test with ethernet-phy.yaml?
$nodename:
pattern: "^ethernet-phy(@[a-f0-9]+)?$"
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reset-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <20000>;
> + reset-deassert-us = <100000>;
> + reg = <0x0>;
Sort order is:
compatible
reg
(interrupts)
The rest in alphabetical order.
> + };
> +};
> +
> +&mdio1 {
> + rgmii_phy1: phy@0 {
dito
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reset-gpios = <&gpio2 RK_PD1 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <20000>;
> + reset-deassert-us = <100000>;
> + reg = <0x0>;
dito
> + };
> +};
> +
> &sdhci {
> bus-width = <8>;
> max-frequency = <200000000>;
>
next prev parent reply other threads:[~2021-07-28 16:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 16:10 [PATCH 0/2] add ethernet support to rk3568 dts Michael Riesch
2021-07-28 16:10 ` [PATCH 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Michael Riesch
2021-07-28 16:43 ` Heiko Stübner
2021-07-28 17:34 ` Heiko Stübner
2021-07-28 16:10 ` [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Michael Riesch
2021-07-28 16:45 ` Johan Jonker [this message]
2021-07-28 17:55 ` Andrew Lunn
2021-07-28 18:29 ` Peter Geis
2021-07-28 20:37 ` Andrew Lunn
2021-07-29 9:07 ` Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5932de-bd6c-de5e-d130-5252f98a12c7@gmail.com \
--to=jbx6244@gmail.com \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).