From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161842AbdAHKE7 (ORCPT ); Sun, 8 Jan 2017 05:04:59 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:42980 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937428AbdAHJs1 (ORCPT ); Sun, 8 Jan 2017 04:48:27 -0500 Subject: Re: [PATCH 07/22] dt-bindings: power: supply: add AXP20X/AXP22X AC power supply To: Chen-Yu Tsai , Quentin Schulz References: <20170102163723.7939-1-quentin.schulz@free-electrons.com> <20170102163723.7939-8-quentin.schulz@free-electrons.com> <20170104131410.mni7opxnouzagypu@rob-hp-laptop> Cc: Rob Herring , knaack.h@gmx.de, Lars-Peter Clausen , Peter Meerwald-Stadler , Mark Rutland , Sebastian Reichel , Russell King , Maxime Ripard , Lee Jones , linux-iio@vger.kernel.org, devicetree , linux-kernel , "open list:THERMAL" , linux-arm-kernel , Thomas Petazzoni , Icenowy Zheng , =?UTF-8?Q?Bruno_Pr=c3=a9mont?= From: Jonathan Cameron Message-ID: Date: Sat, 7 Jan 2017 14:26:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/17 01:17, Chen-Yu Tsai wrote: > Hi Quentin, > > On Wed, Jan 4, 2017 at 9:14 PM, Rob Herring wrote: >> On Mon, Jan 02, 2017 at 05:37:07PM +0100, Quentin Schulz wrote: >>> The X-Powers AXP20X and AXP22X PMICs have an AC entry to supply power to >>> the board. They have a few registers dedicated to the status of the AC >>> power supply. >>> >>> This adds the DT binding documentation for the AC power supply for >>> AXP20X and AXP22X PMICs. >>> >>> Signed-off-by: Quentin Schulz >>> --- >>> .../bindings/power/supply/axp20x_ac_power.txt | 28 ++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_ac_power.txt >>> >>> diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_ac_power.txt b/Documentation/devicetree/bindings/power/supply/axp20x_ac_power.txt >>> new file mode 100644 >>> index 0000000..16d0de4 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/power/supply/axp20x_ac_power.txt >>> @@ -0,0 +1,28 @@ >>> +AXP20X and AXP22X PMICs' AC power supply >>> + >>> +Required Properties: >>> + - compatible: One of: >>> + "x-powers,axp202-ac-power-supply" >>> + "x-powers,axp221-ac-power-supply" >>> + >>> +More Required Properties for AXP20X PMICs: >>> + - io-channels: phandles to ACIN voltage and current ADC channels >>> + - io-channel-names = "acin_v", "acin_i"; >>> + >>> +This node is a subnode of the axp20x PMIC. >>> + >>> +The AXP20X can read the current current and voltage supplied by AC by >>> +reading ADC channels from the AXP20X ADC. >>> + >>> +The AXP22X is only able to tell if an AC power supply is present and >>> +usable. >>> + >>> +Example: >>> + >>> +&axp209 { >>> + ac_power_supply: ac_power_supply { >> >> power-supply { >> >>> + compatible = "x-powers,axp202-ac-power-supply"; >>> + io-channels = <&axp209_adc 0>, <&axp209_adc 1>; >> >> Is this assignment fixed? If so, then it doesn't need to be in DT. > > Is there any case that we actually need to use the IIO channels > from the device tree? Seems to me its limited to the other AXP > sub-devices. > > If so you could use struct iio_map to map the channels to other > devices by name. See axp288_adc for an example. Agreed. When we are within a device (so it's not flexible) that is the way to go. > > Regards > ChenYu > >>> + io-channel-names = "acin_v", "acin_i"; >>> + }; >>> +}; >>> -- >>> 2.9.3 >>> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >