From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E191C04AB1 for ; Mon, 13 May 2019 08:15:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A5ED208C3 for ; Mon, 13 May 2019 08:15:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbfEMIPi (ORCPT ); Mon, 13 May 2019 04:15:38 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:36543 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727355AbfEMIPg (ORCPT ); Mon, 13 May 2019 04:15:36 -0400 Received: from [192.168.178.187] ([109.104.33.66]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MJn4B-1h66Hp0HGb-00K6ce; Mon, 13 May 2019 10:14:56 +0200 Subject: Re: [PATCH 3/3] pinctrl: bcm2835: bcm7211: Add support for 7211 pull-up functionality To: Florian Fainelli , linux-arm-kernel@lists.infradead.org Cc: Al Cooper , Linus Walleij , Rob Herring , Mark Rutland , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Eric Anholt , Doug Berger , Matheus Castello , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Lukas Wunner , Nathan Chancellor , "open list:PIN CONTROL SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , open list References: <20190509205955.27842-1-f.fainelli@gmail.com> <20190509205955.27842-4-f.fainelli@gmail.com> From: Stefan Wahren Message-ID: Date: Mon, 13 May 2019 10:14:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190509205955.27842-4-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:JTDUvpLHa55zi/Dt55qLS5DnQOpaKejjGcxYKJuoM3QMrg+B7VB Ju+vfuIH5aKRFYZw3Uv4K6D3655pRM1/ONqdhNQTFDyvu9HM1JoT34nKKiD5Hi6qOKcd7Ea D+HXoXJxGz0ZIUstZGYcUjC0U25iBgls+nm+kfvMqGbENikB+9ieM+pDQ+Z6gDUdTyX0hle DeQgMZt6X6SlwI8J3KFmQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Gw7Ftq56uJE=:92NT/03PgfE3f83odq3HvL dpxhCqrSNO7BiiIC7zrVKWY3Cn1vSQvVudmD24jW/ejbGXwCpqgG+yEsIQ3Q7oE4fin7aUjsd OBFK0ETfwUfzQ3XH8X4BLEC2UIzm/IUbRZZPRk2khHXAgDa2T8Vxlby897F0mfTcYH33SDSTt zlffYsv8CF8lOmeLDPL1u3zm663HbKLDKEp27yc2Ypz835O8A9ADNBzMmHRjcZiCAHzQrkZgf QseOxHcW5Wcc2oYLFgnBqR4V5Nrv/yuH/2MpmjAr7h2IgOkABPWEp9XqMb6Tb9SijqLYv/svX waOlE6thf453fwxYdACkHDYGmplXopB/66ytGOVvd/+VqDNUjgaRjNJ841sJg8KZ0G3YcZwlF fDKv2EVVJLnS9uJ9NZVUX08H+EgFM0QmqDdYzjrMrSrTQu96zVwuu9WPfpp+Az7XgAPVn2d4y iJsItBTET3Uzi3fvzKM/JreNrON9bbhEsJrdBh6bws14jyarfegmUBkZKQHB8F2bT9aIV0V+9 WwMa4COsyZIXojuELWY6i73eSvJT3gHI1pCqXqLVanfPfYS1E6h1OipKAL4akrEQrwMhCZEpf UEbdpNY3CEzdcYwKGVMqUnHex+7tWJvAdOFh5c9fyRUSiO1SUkHbNLyfnIMQQ9xHAY7o6xi0B l0NXjJeFt37NWgGmfE5XqYqU7ZBHJP0sTFpRoeZIov66r+DSPgCOiRnkO8U8ssGLUhhaFaB1f 0DIBAf5L21lAwyKKKEqOoY6XdqNXeUzooClAbqx0+pCrwRnFPIiEklJm76c= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On 09.05.19 22:59, Florian Fainelli wrote: > From: Al Cooper > > The 7211 has a new way of selecting the pull-up/pull-down setting > for a GPIO pin. The registers used for the bcm2837, GP_PUD and > GP_PUDCLKn0, are no longer connected. A new set of registers, > GP_GPIO_PUP_PDN_CNTRL_REGx must be used. This commit will add > a new compatible string "brcm,bcm7211-gpio" and the kernel > driver will use it to select which method is used to select > pull-up/pull-down. > > Signed-off-by: Al Cooper > Signed-off-by: Florian Fainelli > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 85 +++++++++++++++++++++++++-- > 1 file changed, 80 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 183d1ffe6a75..35d9f9593000 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -57,15 +57,26 @@ > #define GPAFEN0 0x88 /* Pin Async Falling Edge Detect */ > #define GPPUD 0x94 /* Pin Pull-up/down Enable */ > #define GPPUDCLK0 0x98 /* Pin Pull-up/down Enable Clock */ > +#define GP_GPIO_PUP_PDN_CNTRL_REG0 0xe4 /* 7211 Pin Pull-up/down select */ > > #define FSEL_REG(p) (GPFSEL0 + (((p) / 10) * 4)) > #define FSEL_SHIFT(p) (((p) % 10) * 3) > #define GPIO_REG_OFFSET(p) ((p) / 32) > #define GPIO_REG_SHIFT(p) ((p) % 32) > > +#define PUD_7211_MASK 0x3 > +#define PUD_7211_REG_OFFSET(p) ((p) / 16) > +#define PUD_7211_REG_SHIFT(p) (((p) % 16) * 2) > + > /* argument: bcm2835_pinconf_pull */ > #define BCM2835_PINCONF_PARAM_PULL (PIN_CONFIG_END + 1) > > +enum bcm7211_pinconf_pull { > + BCM7211_PINCONFIG_PULL_NONE, > + BCM7211_PINCONFIG_PULL_UP, > + BCM7211_PINCONFIG_PULL_DOWN, > +}; unfortunately this not usable for DTS files. Please look at: include/dt-bindings/pinctrl/bcm2835.h Btw the meaning between BCM2835 and BCM7211 of pull down and up is different :(