From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] iio: bme680_i2c: Remove ACPI support
Date: Thu, 06 May 2021 07:37:57 -0700 [thread overview]
Message-ID: <eb9aaace58730082253eae3c577136bb05ac82af.camel@perches.com> (raw)
In-Reply-To: <CAHp75VdHMm+WYA2Nfiz1g3B5Sj14Rq601aSyQ_puynudg9ZiZw@mail.gmail.com>
On Thu, 2021-05-06 at 17:31 +0300, Andy Shevchenko wrote:
> On Thu, May 6, 2021 at 4:50 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > On Thu, May 06, 2021 at 03:42:08PM +0200, Hans de Goede wrote:
> > > On 5/6/21 3:37 PM, Guenter Roeck wrote:
>
> ...
>
> > > We (mostly Andy and me) are not even 100% sure this one is
> > > a fake ACPI ID, but we do pretty strongly believe that it is.
> > >
> >
> > What a mess :-(
>
> What we can do is a checkpatch-alike check for vendor ID to be
> registered in [1] and issue a warning if not. At least it alerts
> maintainers. Joe, do you think it is doable or we should have a
> separate tool for that? (Because I have no clue how checkpatch
> cohabits with internet connection, otherwise the problem with
> synchronisation of that registry might be a problem)
Perhaps best to have a separate scriptable tool and if necessary
have checkpatch use it like the spdxcheck block.
scripts/checkpatch.pl-sub is_SPDX_License_valid {
scripts/checkpatch.pl- my ($license) = @_;
scripts/checkpatch.pl-
scripts/checkpatch.pl: return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$gitroot"));
scripts/checkpatch.pl-
scripts/checkpatch.pl- my $root_path = abs_path($root);
scripts/checkpatch.pl: my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
scripts/checkpatch.pl- return 0 if ($status ne "");
scripts/checkpatch.pl- return 1;
scripts/checkpatch.pl-}
[]
scripts/checkpatch.pl- } elsif ($rawline =~ /(SPDX-License-Identifier: .*)/) {
scripts/checkpatch.pl- my $spdx_license = $1;
scripts/checkpatch.pl: if (!is_SPDX_License_valid($spdx_license)) {
scripts/checkpatch.pl- WARN("SPDX_LICENSE_TAG",
scripts/checkpatch.pl- "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
scripts/checkpatch.pl- }
next prev parent reply other threads:[~2021-05-06 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 3:43 [PATCH v2] iio: bme680_i2c: Remove ACPI support Guenter Roeck
2021-05-06 8:29 ` Hans de Goede
2021-05-06 9:28 ` Andy Shevchenko
2021-05-06 13:37 ` Guenter Roeck
2021-05-06 13:42 ` Hans de Goede
2021-05-06 13:50 ` Guenter Roeck
2021-05-06 14:31 ` Andy Shevchenko
2021-05-06 14:37 ` Joe Perches [this message]
2021-05-06 14:27 ` Andy Shevchenko
2021-05-07 9:31 ` Jonathan Cameron
2021-05-07 13:34 ` Guenter Roeck
2021-05-08 3:09 ` Guenter Roeck
[not found] ` <CAHp75Vfa3GT9bnimxw7EJsJyRF8HZP3PGsUNikSScuNiU4qArg@mail.gmail.com>
2021-05-08 9:41 ` Hans de Goede
2021-05-08 9:47 ` Hans de Goede
2021-05-08 15:24 ` Guenter Roeck
2021-05-08 15:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb9aaace58730082253eae3c577136bb05ac82af.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).