From: Shaokun Zhang <zhangshaokun@hisilicon.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, yuqi jin <jinyuqi@huawei.com>,
"Mike Rapoport" <rppt@linux.ibm.com>,
Paul Burton <paul.burton@mips.com>,
"Michal Hocko" <mhocko@suse.com>,
Michael Ellerman <mpe@ellerman.id.au>,
"Anshuman Khandual" <anshuman.khandual@arm.com>
Subject: Re: [PATCH v3] lib: optimize cpumask_local_spread()
Date: Fri, 8 Nov 2019 13:50:05 +0800 [thread overview]
Message-ID: <ebc1b33d-ee59-a662-89ae-ae5a7e340d56@hisilicon.com> (raw)
In-Reply-To: <20191107194942.734bc867e1c9578d07cf1712@linux-foundation.org>
Hi Andrew,
On 2019/11/8 11:49, Andrew Morton wrote:
> On Thu, 7 Nov 2019 09:44:08 +0800 Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
>
>> In the multi-processors and NUMA system, I/O driver will find cpu cores
>> that which shall be bound IRQ. When cpu cores in the local numa have
>> been used, it is better to find the node closest to the local numa node,
>> instead of choosing any online cpu immediately.
>>
>> On Huawei Kunpeng 920 server, there are 4 NUMA node(0 -3) in the 2-cpu
>> system(0 - 1). We perform PS (parameter server) business test, the
>> behavior of the service is that the client initiates a request through
>> the network card, the server responds to the request after calculation.
>> When two PS processes run on node2 and node3 separately and the
>> network card is located on 'node2' which is in cpu1, the performance
>> of node2 (26W QPS) and node3 (22W QPS) was different.
>> It is better that the NIC queues are bound to the cpu1 cores in turn,
>> then XPS will also be properly initialized, while cpumask_local_spread
>> only considers the local node. When the number of NIC queues exceeds
>> the number of cores in the local node, it returns to the online core
>> directly. So when PS runs on node3 sending a calculated request,
>> the performance is not as good as the node2. It is considered that
>> the NIC and other I/O devices shall initialize the interrupt binding,
>> if the cores of the local node are used up, it is reasonable to return
>> the node closest to it.
>>
>> Let's optimize it and find the nearest node through NUMA distance for the
>> non-local NUMA nodes. The performance will be better if it return the
>> nearest node than the random node.
>>
>> After this patch, the performance of the node3 is the same as node2
>> that is 26W QPS when the network card is still in 'node2'. Since it will
>> return the closest non-local NUMA code rather than random node, it is no
>> harm to others at least.
>
> This is a little nicer:
>
> --- a/lib/cpumask.c~lib-optimize-cpumask_local_spread-v3-fix
> +++ a/lib/cpumask.c
> @@ -254,7 +254,6 @@ static unsigned int __cpumask_local_spre
> BUG();
> }
>
> -static DEFINE_SPINLOCK(spread_lock);
> /**
> * cpumask_local_spread - select the i'th cpu with local numa cpu's first
> * @i: index number
> @@ -270,6 +269,7 @@ unsigned int cpumask_local_spread(unsign
> {
> static int node_dist[MAX_NUMNODES];
> static bool used[MAX_NUMNODES];
> + static DEFINE_SPINLOCK(spread_lock);
Good catch, thanks for fixing it.
Shaokun.
> unsigned long flags;
> int cpu, j, id;
>
> _
>
>
> .
>
next prev parent reply other threads:[~2019-11-08 5:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 1:44 [PATCH v3] lib: optimize cpumask_local_spread() Shaokun Zhang
2019-11-08 3:49 ` Andrew Morton
2019-11-08 5:50 ` Shaokun Zhang [this message]
2019-11-08 10:31 ` Michal Hocko
2019-11-11 2:02 ` Shaokun Zhang
2019-11-12 11:56 ` Michal Hocko
2019-11-13 2:46 ` Shaokun Zhang
2019-11-14 14:43 ` Michal Hocko
2019-11-15 9:09 ` Shaokun Zhang
2019-11-15 13:36 ` Michal Hocko
2019-11-21 8:14 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebc1b33d-ee59-a662-89ae-ae5a7e340d56@hisilicon.com \
--to=zhangshaokun@hisilicon.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=jinyuqi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).