From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A753C77B7F for ; Fri, 12 May 2023 07:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239947AbjELHZ4 (ORCPT ); Fri, 12 May 2023 03:25:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239970AbjELHZw (ORCPT ); Fri, 12 May 2023 03:25:52 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BFEE171C; Fri, 12 May 2023 00:25:51 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id C42DA24E2CF; Fri, 12 May 2023 15:25:48 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 12 May 2023 15:25:48 +0800 Received: from [192.168.125.131] (113.72.146.187) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 12 May 2023 15:25:47 +0800 Message-ID: Date: Fri, 12 May 2023 15:24:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 5/7] dt-bindings: soc: starfive: Add StarFive syscon module Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley CC: , , "Michael Turquette" , Stephen Boyd , Krzysztof Kozlowski , Philipp Zabel , Conor Dooley , "Emil Renner Berthing" , Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , William Qiu , , References: <20230512022036.97987-1-xingyu.wu@starfivetech.com> <20230512022036.97987-6-xingyu.wu@starfivetech.com> <2fb8c88a-dab5-791b-eefe-c983decad5e8@linaro.org> <20230512-brewery-spouse-86350c9664d8@wendy> From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.187] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/12 14:50, Krzysztof Kozlowski wrote: > On 12/05/2023 08:43, Conor Dooley wrote: >> On Fri, May 12, 2023 at 08:35:43AM +0200, Krzysztof Kozlowski wrote: >>> On 12/05/2023 04:20, Xingyu Wu wrote: >>>> From: William Qiu >> >>>> + "#power-domain-cells": >>>> + const: 1 >>> >>> Add it to the existing examples. >>> >>> This part confuses me... why aon appeared here? Why power-controller >>> disappeared? I don't think that Rob or me proposed any of this. >> >> Rob did actually suggest this, as the power-controller child node had no >> properties other than #power-domain-cells. > > He suggested it for aon, but not for stg or sys... aon is not a child of > sys, is it? Then why power-controller disappeared from sys? > The power-controller is only for aon, but now just use power-domain-cells instead. The sys only have the clock-controller child node not power-controller. And stg has neither. Best regards, Xingyu Wu