From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85870C43461 for ; Fri, 30 Apr 2021 19:33:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63D35613EA for ; Fri, 30 Apr 2021 19:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbhD3Tds (ORCPT ); Fri, 30 Apr 2021 15:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbhD3Tdq (ORCPT ); Fri, 30 Apr 2021 15:33:46 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9272BC06138B; Fri, 30 Apr 2021 12:32:56 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id z6so10498718wrm.4; Fri, 30 Apr 2021 12:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YGxJur6BpkCaw3OzABXrg+qG7M6lysHFEiPjPM8O8jM=; b=XbBK4VfeB5HSc9VnsPbCGaLMOUGma5aINBFJEeaHajUizyf/o35ykT8yudbK0WOGRs 7EbWBY9Y0f16Et0zoxlGpoDFxWbUapu0El35CKgPAXRHwtRVvkQLgtar//qiWYhxKNz4 39l2EMmUMRIhPnK9jjQxB1YPA/YgzjHRe5QMBCLNeLk4460d1NOwtPiLTAQqObmdSUxq uB/wFVzfVbRAxW84BGVd/NwRSCgz8TWy7JVXgvNKDeNFh/yWZVMIk6vcuUVD3jsM6fMT QPjev0ngvs7RqRqiNU61+km8kxYP9M2ieCHzn5mOmlUJAq3znWycBeDb46OJgDuuUPU5 MmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YGxJur6BpkCaw3OzABXrg+qG7M6lysHFEiPjPM8O8jM=; b=REfJ54hxvYNUc9owpfZV+eDSiPuO+08p/owZc3c4H0KYY/SD3qFjUUk0S5Jfs8OuB7 L6mJ4Qv/1+vFEBLvS4/NJCxirqloo4m3z6aMjwDvA1lpgAwNno79rw/flPaSGYkqBTMw 6aMg/CFgtQxk2Cub/8244esZN4mdrHaOiyeC9F6T/Uxnz3v1wExEc+lt3kK/ZfVlSQMB EnTZHCLlxd6zzGOaizy55F79y7ctD3VqHsvPiTPDmdvAI7rrbcNBntacYo0umvF56NJ4 KPSezAb9EYM3NP7zhqVHwXpOenU2YATfkfsvxrtBcmg32eCtmgM5If5TgRVMVovJbgIU yKfQ== X-Gm-Message-State: AOAM53294UVyAjo48N0zwni7soHi4gTfSOJf0J4rBs3MCoEyCmdjKViv mGkVjdwoefW9QwVp+vyuq1871vO4YqEYXQ== X-Google-Smtp-Source: ABdhPJyhTths+KvVLUS8knCdFfcch3pczopIQyF+cUUbjW4A7vhF++ZfvubKihT1guzh9Wvy0oBFMw== X-Received: by 2002:adf:dfcd:: with SMTP id q13mr9248597wrn.363.1619811174183; Fri, 30 Apr 2021 12:32:54 -0700 (PDT) Received: from [192.168.0.160] ([170.253.36.171]) by smtp.gmail.com with ESMTPSA id m2sm13348394wmq.15.2021.04.30.12.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 12:32:53 -0700 (PDT) Subject: Re: netdevice.7 SIOCGIFFLAGS/SIOCSIFFLAGS To: Erik Flodin , mtk.manpages@gmail.com Cc: linux-man@vger.kernel.org, Stefan Rompf , "David S. Miller" , John Dykstra , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <1cde5a72-033e-05e7-be58-b1b2ef95c80f@gmail.com> From: "Alejandro Colomar (man-pages)" Message-ID: Date: Fri, 30 Apr 2021 21:32:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [PING mtk, netdev@] [CC += linux-kernel] Hi Erik, On 4/29/21 9:45 PM, Erik Flodin wrote: > On Wed, 14 Apr 2021 at 21:56, Alejandro Colomar (man-pages) > wrote: >> >> [CC += netdev] >> >> Hi Erik, >> >> On 4/14/21 8:52 PM, Erik Flodin wrote: >>> Hi, >>> >>> On Fri, 19 Mar 2021 at 20:53, Alejandro Colomar (man-pages) >>> wrote: >>>> On 3/17/21 3:12 PM, Erik Flodin wrote: >>>>> The documentation for SIOCGIFFLAGS/SIOCSIFFLAGS in netdevice.7 lists >>>>> IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO, but those can't be set in >>>>> ifr_flags as it is only a short and the flags start at 1<<16. >>>>> >>>>> See also https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=746e6ad23cd6fec2edce056e014a0eabeffa838c >>>>> >>>> >>>> I don't know what's the history of that. >>> >>> Judging from commit message in the commit linked above it was added by >>> mistake. As noted the flags are accessible via netlink, just not via >>> SIOCGIFFLAGS. >>> >>> // Erik >>> >> >> I should have CCd netdev@ before. Thanks for the update. Let's see if >> anyone there can comment. >> >> Thanks, >> >> Alex >> > Hi again, > > Have there been any updates on this one? No, Noone from the kernel answered. And I'm sorry, but I'm not sure what is going on in the code, so I don't want to close this here by just removing those flags from the manual page, because I worry that the actual code may be wrong or something. So I prefer that when Michael has some time he can maybe review this and say something. Ideally, someone from the kernel would also respond, but they haven't. I've CCd the LKML; let's see if someone reads this and can help. Thanks, Alex P.S.: Please, if we haven't responded in a month from now, ping us again. Thanks again. > > // Erik > >> >> -- >> Alejandro Colomar >> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ >> http://www.alejandro-colomar.es/ -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/