From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v3 2/2] Support interactive annotation of code without symbols
Date: Mon, 24 Feb 2020 19:26:57 +0530 [thread overview]
Message-ID: <ec14c25e-e868-a073-2799-55d55ae23e1f@linux.ibm.com> (raw)
In-Reply-To: <20200224022225.30264-3-yao.jin@linux.intel.com>
On 2/24/20 7:52 AM, Jin Yao wrote:
> For perf report on stripped binaries it is currently impossible to do
> annotation. The annotation state is all tied to symbols, but there are
> either no symbols, or symbols are not covering all the code.
>
> We should support the annotation functionality even without symbols.
>
> This patch fakes a symbol and the symbol name is the string of address.
> After that, we just follow current annotation working flow.
>
> For example,
>
> 1. perf report
>
> Overhead Command Shared Object Symbol
> 20.67% div libc-2.27.so [.] __random_r
> 17.29% div libc-2.27.so [.] __random
> 10.59% div div [.] 0x0000000000000628
> 9.25% div div [.] 0x0000000000000612
> 6.11% div div [.] 0x0000000000000645
>
> 2. Select the line of "10.59% div div [.] 0x0000000000000628" and ENTER.
>
> Annotate 0x0000000000000628
> Zoom into div thread
> Zoom into div DSO (use the 'k' hotkey to zoom directly into the kernel)
> Browse map details
> Run scripts for samples of symbol [0x0000000000000628]
> Run scripts for all samples
> Switch to another data file in PWD
> Exit
>
> 3. Select the "Annotate 0x0000000000000628" and ENTER.
>
> Percent│
> │
> │
> │ Disassembly of section .text:
> │
> │ 0000000000000628 <.text+0x68>:
> │ divsd %xmm4,%xmm0
> │ divsd %xmm3,%xmm1
> │ movsd (%rsp),%xmm2
> │ addsd %xmm1,%xmm0
> │ addsd %xmm2,%xmm0
> │ movsd %xmm0,(%rsp)
This might be an add on...
Even though there are samples on a particular instruction, 'Percent' column
is empty, I guess, because we don't have symbol length?
Should we show 'global percent'? Or nr samples? Will it be useful?
Ravi
next prev parent reply other threads:[~2020-02-24 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 2:22 [PATCH v3 0/2] perf report: Support annotation of code without symbols Jin Yao
2020-02-24 2:22 ` [PATCH v3 1/2] perf util: Print al_addr when symbol is not found Jin Yao
2020-02-24 2:22 ` [PATCH v3 2/2] Support interactive annotation of code without symbols Jin Yao
2020-02-24 12:35 ` Jiri Olsa
2020-02-24 15:39 ` Jin, Yao
2020-02-24 20:46 ` Jiri Olsa
2020-02-24 13:25 ` Ravi Bangoria
2020-02-24 13:51 ` Jiri Olsa
2020-02-24 14:04 ` Ravi Bangoria
2020-02-24 15:53 ` Jin, Yao
2020-02-24 15:44 ` Jin, Yao
2020-02-24 13:56 ` Ravi Bangoria [this message]
2020-02-24 15:46 ` Jin, Yao
2020-02-27 13:50 ` [PATCH v3 0/2] perf report: Support " Arnaldo Carvalho de Melo
2020-02-27 14:47 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec14c25e-e868-a073-2799-55d55ae23e1f@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).