From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbdBFW0m (ORCPT ); Mon, 6 Feb 2017 17:26:42 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37136 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbdBFW0k (ORCPT ); Mon, 6 Feb 2017 17:26:40 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1B75560A01 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] arm64: kconfig: allow support for memory failure handling To: Punit Agrawal References: <1485985115-27274-1-git-send-email-tbaicar@codeaurora.org> <8737fvqlxs.fsf@e105922-lin.cambridge.arm.com> Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Jonathan (Zhixiong) Zhang" From: "Baicar, Tyler" Message-ID: Date: Mon, 6 Feb 2017 15:26:37 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8737fvqlxs.fsf@e105922-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Punit, On 2/3/2017 9:27 AM, Punit Agrawal wrote: > Tyler Baicar writes: > >> From: "Jonathan (Zhixiong) Zhang" >> >> If ACPI_APEI and MEMORY_FAILURE is configured, select >> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery >> when such memory failure is reported through ACPI APEI. APEI >> (ACPI Platform Error Interfaces) provides a means for the >> platform to convey error information to the kernel. >> >> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support >> memory failure recovery attempt. >> >> Signed-off-by: Jonathan (Zhixiong) Zhang >> Signed-off-by: Tyler Baicar >> --- >> arch/arm64/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index f92778d..4cd12a0 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -15,6 +15,8 @@ config ARM64 >> select ARCH_HAS_SG_CHAIN >> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST >> select ARCH_USE_CMPXCHG_LOCKREF >> + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE >> + select ARCH_SUPPORTS_MEMORY_FAILURE > Although enabling support for memory failure handling makes sense in the > architecture config, it feels out of place to select > ACPI_APEI_MEMORY_FAILURE here. > > Maybe key it off of CONFIG_APEI? Yes, I can move it there. config ACPI_APEI bool "ACPI Platform Error Interface (APEI)" select MISC_FILESYSTEMS select PSTORE select UEFI_CPER + select ACPI_APEI_MEMORY_FAILURE if MEMORY_FAILURE depends on HAVE_ACPI_APEI The ARCH_SUPPORTS_MEMORY_FAILURE should remain in arch/arm64/Kconfig though, correct? Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.