From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0635C33CA1 for ; Tue, 7 Jan 2020 13:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D096F207E0 for ; Tue, 7 Jan 2020 13:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728080AbgAGNYx (ORCPT ); Tue, 7 Jan 2020 08:24:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:46774 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727658AbgAGNYw (ORCPT ); Tue, 7 Jan 2020 08:24:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6475DAD73; Tue, 7 Jan 2020 13:24:50 +0000 (UTC) Subject: Re: [PATCH] drm/modes: tag unused variables to avoid warnings To: Benjamin Gaignard , jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, yakui.zhao@intel.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20191210102437.19377-1-benjamin.gaignard@st.com> From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: Date: Tue, 7 Jan 2020 14:24:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20191210102437.19377-1-benjamin.gaignard@st.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LHNsfGAK4PHadNV60bXWhRMsy5DJYiLCb" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LHNsfGAK4PHadNV60bXWhRMsy5DJYiLCb Content-Type: multipart/mixed; boundary="ahJGr5M4OVDuuokVZDWiPJsUaLtTrGqOW"; protected-headers="v1" From: Thomas Zimmermann To: Benjamin Gaignard , jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, yakui.zhao@intel.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH] drm/modes: tag unused variables to avoid warnings References: <20191210102437.19377-1-benjamin.gaignard@st.com> In-Reply-To: <20191210102437.19377-1-benjamin.gaignard@st.com> --ahJGr5M4OVDuuokVZDWiPJsUaLtTrGqOW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 10.12.19 um 11:24 schrieb Benjamin Gaignard: > Some variables are set but never used. To avoid warning when compiling > with W=3D1 and keep the algorithm like it is tag theses variables > with _maybe_unused macro. >=20 > Signed-off-by: Benjamin Gaignard Acked-by: Thomas Zimmermann > --- > changes in this version: > - do not modify the code to remove the unused variables > just prefix them with __maybe_unused macro. > =20 > drivers/gpu/drm/drm_modes.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index 88232698d7a0..70aed4e2990d 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -233,7 +233,7 @@ struct drm_display_mode *drm_cvt_mode(struct drm_de= vice *dev, int hdisplay, > /* 3) Nominal HSync width (% of line period) - default 8 */ > #define CVT_HSYNC_PERCENTAGE 8 > unsigned int hblank_percentage; > - int vsyncandback_porch, vback_porch, hblank; > + int vsyncandback_porch, __maybe_unused vback_porch, hblank; > =20 > /* estimated the horizontal period */ > tmp1 =3D HV_FACTOR * 1000000 - > @@ -386,9 +386,10 @@ drm_gtf_mode_complex(struct drm_device *dev, int h= display, int vdisplay, > int top_margin, bottom_margin; > int interlace; > unsigned int hfreq_est; > - int vsync_plus_bp, vback_porch; > - unsigned int vtotal_lines, vfieldrate_est, hperiod; > - unsigned int vfield_rate, vframe_rate; > + int vsync_plus_bp, __maybe_unused vback_porch; > + unsigned int vtotal_lines, __maybe_unused vfieldrate_est; > + unsigned int __maybe_unused hperiod; > + unsigned int vfield_rate, __maybe_unused vframe_rate; > int left_margin, right_margin; > unsigned int total_active_pixels, ideal_duty_cycle; > unsigned int hblank, total_pixels, pixel_freq; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --ahJGr5M4OVDuuokVZDWiPJsUaLtTrGqOW-- --LHNsfGAK4PHadNV60bXWhRMsy5DJYiLCb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl4Uhp0ACgkQaA3BHVML eiNdxwf/eBW4rz48DTfwxq5usxvjoxgc2HDvgUYY058/0XJJzuh5lmm3HOWuC32L dyJjcOGL3rA5jNPk5rqljTS4ZPkyv+sc1VuwBeMGbpJX2lgzCbUnbiPT4+kqdnmY aqCiC9H3UJRhYkFCb4Viv9zU1Oj9GlF28i0RqipxJmqvF2g4HGH5kjHx0JFDxkzg +yoZ2eBxlhBrQj+iCA9HQBpUVJgI/ThyTl9kCVP9l4xHfQwGfUa/LXpEYqaL54Sh cEhrCv/2CDyug0Jz1J6MDfMt/YkNbb4AG2t2NrYEwQhxZ66aNvUyxaMCzvCcYzTW S1KywNgoGAYqTQzMr+6eQ72yQzLM4A== =kZQw -----END PGP SIGNATURE----- --LHNsfGAK4PHadNV60bXWhRMsy5DJYiLCb--