From: Hugh Dickins <hughd@google.com>
To: David Howells <dhowells@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steve French <smfrench@gmail.com>,
Steve French <stfrench@microsoft.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Tom Talpey <tom@talpey.com>, Paulo Alcantara <pc@cjr.nz>,
Jeff Layton <jlayton@kernel.org>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: Obsolete comment on page swizzling (written by Hugh)?
Date: Tue, 21 Feb 2023 14:41:21 -0800 (PST) [thread overview]
Message-ID: <ec3b5661-e99-fb46-b678-66a7daf43d82@google.com> (raw)
In-Reply-To: <2890066.1676993700@warthog.procyon.org.uk>
On Tue, 21 Feb 2023, David Howells wrote:
> David Howells <dhowells@redhat.com> wrote:
>
> > > > + /* At this point we hold neither the i_pages lock nor the
> > > > + * page lock: the page may be truncated or invalidated
> > > > + * (changing page->mapping to NULL), or even swizzled
> > > > + * back from swapper_space to tmpfs file mapping
> > >
> > > Where does this comment come from? This is cifs, not tmpfs. You'll
> > > never be asked to writeback a page from the swap cache. Dirty pages
> > > can be truncated, so the first half of the comment is still accurate.
> > > I'd rather it moved down to below the folio lock, and was rephrased
> > > so it described why we're checking everything again.
> >
> > Actually, it's in v6.2 cifs and I just move it in the patch where I copy the
> > afs writepages implementation into cifs. afs got it in 2007 when I added
> > write support[1] and I suspect I copied it from cifs. cifs got it in 2005
> > when Steve added writepages support[2]. I think he must've got it from
> > fs/mpage.c and the comment there is prehistoric.
>
> The ultimate source is Hugh Dickins, it would seem:
>
> commit 820ef9df32856bb54fe5bc995153feb276420e15
> Author: Andrew Morton <akpm@digeo.com>
> Date: Fri Nov 15 18:52:38 2002 -0800
>
> [PATCH] handle pages which alter their ->mapping
>
> Patch from Hugh Dickins <hugh@veritas.com>
>
> tmpfs failed fsx+swapout tests after many hours, a page found zeroed.
> Not a truncate problem, but mirror image of earlier truncate problems:
> swap goes through mpage_writepages, which must therefore allow for a
> sudden swizzle back to file identity.
>
> Second time this caught us, so I've audited the tree for other places
> which might be surprised by such swizzling. The only others I found
> were (perhaps) in the parisc and sparc64 flush_dcache_page called
> from do_generic_mapping_read on a looped tmpfs file which is also
> mmapped; but that's a very marginal case, I wanted to understand it
> better before making any edit, and now realize that hch's sendfile
> in loop eliminates it (now go through do_shmem_file_read instead:
> similar but crucially this locks the page when raising its count,
> which is enough to keep vmscan from interfering).
>
> Maybe we should delete or amend the comment now?
Yes, that comment does not belong in afs or btrfs or cifs - though it
does explain why we have sometimes chosen to compare folio_mapping(folio)
with expected mapping, rather than against NULL.
But "now" is not the moment to amend it: it looks like these sources
are in flux at present. And truncate_cleanup_folio() has a "swizzles"
comment without even a mapping to compare with.
Hugh
next prev parent reply other threads:[~2023-02-21 22:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 4:29 linux-next: manual merge of the mm-stable tree with the cifs tree Stephen Rothwell
2023-02-20 13:58 ` Matthew Wilcox
2023-02-20 8:01 ` Stephen Rothwell
2023-02-20 20:58 ` Matthew Wilcox
2023-02-21 6:44 ` Stephen Rothwell
2023-02-21 7:19 ` David Howells
2023-02-21 7:42 ` Stephen Rothwell
2023-02-21 14:39 ` David Howells
2023-02-21 14:55 ` Matthew Wilcox
2023-02-21 15:05 ` David Howells
2023-02-21 15:26 ` Matthew Wilcox
2023-02-21 15:20 ` David Howells
2023-02-21 15:30 ` Obsolete comment on page swizzling (written by Hugh)? David Howells
[not found] ` <2890066.1676993700@warthog.procyon.org.uk>
2023-02-21 22:41 ` Hugh Dickins [this message]
2023-02-22 2:49 ` linux-next: manual merge of the mm-stable tree with the cifs tree Stephen Rothwell
2023-02-22 8:27 ` David Howells
2023-02-22 12:13 ` Stephen Rothwell
2023-02-20 21:00 ` Steve French
2023-02-21 6:50 ` Stephen Rothwell
2023-02-20 14:29 ` David Howells
2023-02-20 15:12 ` Matthew Wilcox
2023-02-20 8:05 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3b5661-e99-fb46-b678-66a7daf43d82@google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=rohiths.msft@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=smfrench@gmail.com \
--cc=stfrench@microsoft.com \
--cc=tom@talpey.com \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).