From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1420DC04EBD for ; Tue, 16 Oct 2018 09:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAC3920881 for ; Tue, 16 Oct 2018 09:52:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAC3920881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbeJPRlr (ORCPT ); Tue, 16 Oct 2018 13:41:47 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38736 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726541AbeJPRlr (ORCPT ); Tue, 16 Oct 2018 13:41:47 -0400 Received: by mail-wm1-f67.google.com with SMTP id 193-v6so22500715wme.3 for ; Tue, 16 Oct 2018 02:52:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hBZO2m2vZvZLnjrjlxg4RKjSbsvvDyfiSyX0RSlroWs=; b=UHjZ+vb/c+4BDeHT1v3Cxd3IUuVcxj5E0D2Fvvu/NdH2T1D3bzS0Kvjy2Xs542d2cG tq3k0JMrr3wwf6MAafDU+ckbWiFd5wNV/vb9SysYbXmmoraMijwHfFADge8jqSFwjsey tje400U7GZO2HfKHsNs/VGl5wLHMfhqo8VH1uhISOMqN29M88wTW3O4+wRYShzqapyDe 8VV6eWAPNdtrx35+6Na9i2LZqGLukwp/HONkSqjv39b1rtev2lfUs8j1snktWmVQrTBy S4cdL1AdEoFp1zgM5Oc+XmRkwZwLg8IsvBvv/HbgK6D9U+PNa14UQb48KotQnY9zQ7/8 Mz8Q== X-Gm-Message-State: ABuFfogQHbhFUOtjRsKoKgJ364v327zKiH94HQGtMRiiS0eC8IOrTXGK 2knEmDp2Kn3NenifCVEnO56uKA== X-Google-Smtp-Source: ACcGV63f+DKmNBWarStHW5v//DlNHMAmx2BeJuyD17oGTsQnAbesSHbufpeBOtuaSpDaB6fwuGjmAA== X-Received: by 2002:a1c:dac7:: with SMTP id r190-v6mr16555419wmg.137.1539683527911; Tue, 16 Oct 2018 02:52:07 -0700 (PDT) Received: from [192.168.1.13] ([90.168.169.92]) by smtp.gmail.com with ESMTPSA id y64-v6sm9833191wmg.28.2018.10.16.02.52.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 02:52:07 -0700 (PDT) Subject: Re: [PATCH 3/3] drivers: use probe_err function in obvious cases To: Andrzej Hajda , Greg Kroah-Hartman Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com, Mark Brown References: <20181016072244.1216-1-a.hajda@samsung.com> <20181016072244.1216-4-a.hajda@samsung.com> From: Javier Martinez Canillas Message-ID: Date: Tue, 16 Oct 2018 11:52:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20181016072244.1216-4-a.hajda@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrzej, On 10/16/2018 09:22 AM, Andrzej Hajda wrote: > The patch replaces obviously matching code with probe_err function. > There are many more places where probe_err could be used. > The patch shows how the new function should be used, and how it > improves the code. > > It was generated by cocci script (little bit dirty): > This is great! I guess the easier would be to split these by kernel releases, maybe patch #1 and #2 can land in one kernel release and then each subsystem can merge the changes for their drivers with the dependency already in place. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat