From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
broonie@kernel.org, vkoul@kernel.org
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: wsa881x: mark read_only_wordlength flag
Date: Thu, 12 Mar 2020 09:54:54 +0000 [thread overview]
Message-ID: <ec587d04-274a-32dc-ed2d-cdb8fbdf788d@linaro.org> (raw)
In-Reply-To: <2c56d592-719f-bd87-25cb-c5028bde729b@linux.intel.com>
On 11/03/2020 18:58, Pierre-Louis Bossart wrote:
>
> On 3/11/20 6:35 AM, Srinivas Kandagatla wrote:
>> WSA881x works in PDM mode so the wordlength is fixed, which also makes
>> the only field "WordLength" in DPN_BlockCtrl1 register a read-only.
>> Writing to this register will throw up errors with Qualcomm Controller.
>
> it'd be good to clarify the nature of these errors, i.e.
>
> a) is this the Slave device responding with a NAK?
> b) is this the Slave device responding with COMMAND_IGNORED, and those
> responses not handled by the controller?
> c) something else?
With the current version of Qcom SoundWire controller driver, it can
only know if the write succeeded or not based on completion interrupt.
There are no details of the actual error code visible to the driver. But
the new version of the same controller is expected to return better
error codes.
thanks,
srini
>
> Thanks!
next prev parent reply other threads:[~2020-03-12 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 11:35 [PATCH 0/2] soundwire: add read_only_wordlength flag Srinivas Kandagatla
2020-03-11 11:35 ` [PATCH 1/2] soundwire: stream: Add read_only_wordlength flag to port properties Srinivas Kandagatla
2020-03-20 13:56 ` Vinod Koul
2020-03-11 11:35 ` [PATCH 2/2] ASoC: wsa881x: mark read_only_wordlength flag Srinivas Kandagatla
2020-03-11 18:58 ` Pierre-Louis Bossart
2020-03-12 9:54 ` Srinivas Kandagatla [this message]
2020-03-20 14:02 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec587d04-274a-32dc-ed2d-cdb8fbdf788d@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).