From: David Laight <David.Laight@ACULAB.COM>
To: "'GONG, Ruiqi'" <gongruiqi@huaweicloud.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gongruiqi1@huawei.com" <gongruiqi1@huawei.com>
Subject: RE: [PATCH] clk: renesas: r8a7778: remove checker warnings: x | !y
Date: Wed, 14 Jun 2023 10:17:10 +0000 [thread overview]
Message-ID: <ec5ce50bc3e14f62bbf13c00a661e136@AcuMS.aculab.com> (raw)
In-Reply-To: <20230613025403.3338129-1-gongruiqi@huaweicloud.com>
From: GONG, Ruiqi
> Sent: 13 June 2023 03:54
>
> Eliminate the following Sparse reports when building with C=1:
>
> drivers/clk/renesas/clk-r8a7778.c:85:52: warning: dubious: x | !y
> drivers/clk/renesas/clk-r8a7778.c:87:50: warning: dubious: x | !y
>
> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
> ---
> drivers/clk/renesas/clk-r8a7778.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/renesas/clk-r8a7778.c b/drivers/clk/renesas/clk-r8a7778.c
> index 797556259370..ad1a50f3b0cd 100644
> --- a/drivers/clk/renesas/clk-r8a7778.c
> +++ b/drivers/clk/renesas/clk-r8a7778.c
> @@ -81,11 +81,11 @@ static void __init r8a7778_cpg_clocks_init(struct device_node *np)
>
> BUG_ON(!(mode & BIT(19)));
>
> - cpg_mode_rates = (!!(mode & BIT(18)) << 2) |
> - (!!(mode & BIT(12)) << 1) |
> - (!!(mode & BIT(11)));
Try just adding a << 0 on the last line.
Recent gcc and clang optimise the code to 'shift + and'.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-06-14 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 2:54 [PATCH] clk: renesas: r8a7778: remove checker warnings: x | !y GONG, Ruiqi
2023-06-13 7:39 ` Geert Uytterhoeven
2023-06-14 10:17 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec5ce50bc3e14f62bbf13c00a661e136@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=geert+renesas@glider.be \
--cc=gongruiqi1@huawei.com \
--cc=gongruiqi@huaweicloud.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).