From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26ED1C43217 for ; Tue, 4 Oct 2022 11:19:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbiJDLTm (ORCPT ); Tue, 4 Oct 2022 07:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiJDLTk (ORCPT ); Tue, 4 Oct 2022 07:19:40 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B113B6 for ; Tue, 4 Oct 2022 04:19:36 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id y5so1002280lfl.4 for ; Tue, 04 Oct 2022 04:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=A6XWKxs2Jpf+nDr2Vc3Rkr+Qr/XH1f1qA7BAxLgKido=; b=cqvLdXqsagr5kcaewhfqkJeswzQsOsCweQYXWMcDtw8/jJOKAeWrzeV0MiRG92Tk5c Iid+d3NnsW0DRv2zLdSbKWciFbLjMEU8R5NsIvTF5ZTqh/gROVrtTHeIteNJOP0rvAyz 4pEeNAzL8+WAH0FiH6ConPczbi5+BI/TGJTPA5d59wWDh0qeEVBwAvWj7cTLxxG3ZEgQ Pz0OMRWVLFNSsFEmeu5UvJc653p1QVupmaVXwkQopYcxxEyyLRFcPkA3zLknuqRg1fLJ 5qOQoE3e+oUMah33fJsVepDT4BBT2jxGHJkdPIufs1JmyW80/W6vYTeBsEkXFJycTG/y yezA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=A6XWKxs2Jpf+nDr2Vc3Rkr+Qr/XH1f1qA7BAxLgKido=; b=6fJY7xl5kjhZ8G0yL8FyRvQrVALqYbrTH0NjUyaZRh2jDNwNt/582/XLG3PGTyYL+P ySR5vlEeHvs93Q8Jk8XZFPswvhhpCZvW1sgoOyRmNiZK+iZuIta/M3huAwYyLOkDYNL3 VBqAUwnaXGZBRErB7FQImMv+/qelVPGIp71z5Ahhj5TCFXpVDCooYcj3cQD4lXCRNOMJ 8S7UpSRbsIrPObHUQ3nNlK+qF0TnQC8Pr1S1BKfaZSidBz5YM/km9zbsLDmU2fqi5LIp gnKtR6H6773ytV+CDOw/6GWHiNbOtIvwvNZZ4gna48a17AnRkZmAmKvw6cvmSUtNjGsB 2t7Q== X-Gm-Message-State: ACrzQf2OmwncuIEXwPESf9FZGPLAC3+pOETA36pBizOEZEwK07GyFIog elT3yVxg+tZ6Gyx7+8w9OMr+NQ== X-Google-Smtp-Source: AMsMyM71ILvW++ziuI+MGJfwyGaej1nG2FBbgL4boFT0iAbsyH0SMVvWJ/EYJrCjNb1qjSnx+x4HHg== X-Received: by 2002:a05:6512:b08:b0:4a1:d704:fc59 with SMTP id w8-20020a0565120b0800b004a1d704fc59mr8345629lfu.629.1664882374764; Tue, 04 Oct 2022 04:19:34 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id g19-20020ac25393000000b0049944ab6895sm1877001lfh.260.2022.10.04.04.19.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 04:19:34 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 13:19:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation Content-Language: en-US To: Colin Foster , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn References: <20220926002928.2744638-1-colin.foster@in-advantage.com> <20220926002928.2744638-13-colin.foster@in-advantage.com> From: Krzysztof Kozlowski In-Reply-To: <20220926002928.2744638-13-colin.foster@in-advantage.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/2022 02:29, Colin Foster wrote: > The ocelot-ext driver is another sub-device of the Ocelot / Felix driver > system, which currently supports the four internal copper phys. > > Signed-off-by: Colin Foster > --- > > v3 > * Remove "currently supported" verbage > The Seville and Felix 9959 all list their supported modes following > the sentence "The following PHY interface types are supported". > During V2, I had used "currently supported" to suggest more interface > modes are around the corner, though this had raised questions. > > The suggestion was to drop the entire sentence. I did leave the > modified sentence there because it exactly matches the other two > supported products. > > v2 > * New patch > > --- > .../bindings/net/dsa/mscc,ocelot.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > index 8d93ed9c172c..49450a04e589 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > @@ -54,9 +54,22 @@ description: | > - phy-mode = "1000base-x": on ports 0, 1, 2, 3 > - phy-mode = "2500base-x": on ports 0, 1, 2, 3 > > + VSC7412 (Ocelot-Ext): > + > + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513, > + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS > + processor that natively support Linux. Additionally, all four devices > + support control over external interfaces, SPI and PCIe. The Ocelot-Ext > + driver is for the external control portion. > + > + The following PHY interface types are supported: > + > + - phy-mode = "internal": on ports 0, 1, 2, 3 > + > properties: > compatible: > enum: > + - mscc,vsc7512-switch > - mscc,vsc9953-switch > - pci1957,eef0 > > @@ -258,3 +271,49 @@ examples: > }; > }; > }; > + # Ocelot-ext VSC7512 > + - | > + spi { > + soc@0 { soc in spi is a bit confusing. Does it even pass the tests? You have unit address but no reg. > + compatible = "mscc,vsc7512"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + ethernet-switch@0 { > + compatible = "mscc,vsc7512-switch"; > + reg = <0 0>; 0 is the address on which soc bus? > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "cpu"; > + ethernet = <&mac_sw>; > + phy-handle = <&phy0>; > + phy-mode = "internal"; > + }; > + > + port@1 { > + reg = <1>; > + label = "swp1"; > + phy-mode = "internal"; > + phy-handle = <&phy1>; > + }; > + > + port@2 { > + reg = <2>; > + phy-mode = "internal"; > + phy-handle = <&phy2>; > + }; > + > + port@3 { > + reg = <3>; > + phy-mode = "internal"; > + phy-handle = <&phy3>; > + }; How is this example different than previous one (existing soc example)? If by compatible and number of ports, then there is no much value here. > + }; > + }; > + }; > + }; Best regards, Krzysztof