From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tero Kristo <t-kristo@ti.com>, Adam Ford <aford173@gmail.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
"Tony Lindgren" <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Adam Ford" <adam.ford@logicpd.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts
Date: Tue, 1 Oct 2019 08:07:05 +0300 [thread overview]
Message-ID: <ec718740-bb8f-0d31-3622-89a62bd8fede@ti.com> (raw)
In-Reply-To: <6cd7c9f0-cb26-588b-dfd1-faf462732549@ti.com>
On 30/09/2019 20:48, Tero Kristo wrote:
> Hmmh, after some testing, it seems there is bad stuff happening with the
> divider clock implementation, I am re-working it as of now. Basically
> what is wrong is that with a divider max value of say 16, the driver
> attempts to craft the max value into a mask, but this ends up being
> 0x1f. If the max value is 15, it ends up into 0xf which is correct.
Ok, that explains the max not working.
It doesn't explain the other issue, where the TRM says the max div is
32, but it does not work. But taking the max div from the old SoCs, 16,
is not correct either, as it seems that dividers up to 31 work ok.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-10-01 5:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 19:42 [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts Adam Ford
2019-05-28 11:11 ` Tomi Valkeinen
2019-05-28 15:09 ` Adam Ford
2019-05-28 15:20 ` H. Nikolaus Schaller
2019-05-28 15:53 ` Tomi Valkeinen
2019-05-31 12:13 ` Adam Ford
2019-09-25 20:51 ` Adam Ford
2019-09-26 6:55 ` Tomi Valkeinen
2019-09-26 14:12 ` Adam Ford
2019-09-27 6:21 ` Tomi Valkeinen
2019-09-27 12:13 ` Adam Ford
2019-09-27 13:45 ` Tomi Valkeinen
2019-09-27 7:55 ` Tomi Valkeinen
2019-09-27 12:33 ` Adam Ford
2019-09-27 13:47 ` Tomi Valkeinen
2019-09-27 15:37 ` Tero Kristo
2019-09-27 15:47 ` Tomi Valkeinen
2019-09-30 6:45 ` Tomi Valkeinen
2019-09-30 8:53 ` Tero Kristo
2019-09-30 12:41 ` Adam Ford
2019-09-30 12:47 ` Tero Kristo
2019-09-30 13:17 ` Adam Ford
2019-09-30 13:35 ` Tomi Valkeinen
2019-09-30 13:38 ` H. Nikolaus Schaller
2019-09-30 13:54 ` Adam Ford
2019-09-30 14:04 ` Adam Ford
2019-09-30 14:12 ` Adam Ford
2019-09-30 14:20 ` Tomi Valkeinen
2019-09-30 14:27 ` Tomi Valkeinen
2019-09-30 14:56 ` H. Nikolaus Schaller
2019-09-30 15:10 ` Adam Ford
2019-09-30 17:48 ` Tero Kristo
2019-10-01 5:07 ` Tomi Valkeinen [this message]
2019-10-01 5:12 ` Tero Kristo
2019-10-01 8:12 ` Tero Kristo
2019-10-01 9:31 ` Tomi Valkeinen
2019-10-01 13:06 ` Adam Ford
2019-10-01 13:14 ` Tomi Valkeinen
2019-09-25 21:26 ` Andrew F. Davis
2019-06-13 20:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec718740-bb8f-0d31-3622-89a62bd8fede@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=adam.ford@logicpd.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).