From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F453C433ED for ; Tue, 6 Apr 2021 10:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63685613CA for ; Tue, 6 Apr 2021 10:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245035AbhDFKNt (ORCPT ); Tue, 6 Apr 2021 06:13:49 -0400 Received: from gateway34.websitewelcome.com ([192.185.148.140]:11896 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245032AbhDFKNn (ORCPT ); Tue, 6 Apr 2021 06:13:43 -0400 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 3D88215BB73 for ; Tue, 6 Apr 2021 05:13:33 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id TiiDlMiyNMGeETiiDlvqF3; Tue, 06 Apr 2021 05:13:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UtxOuI/vruadawRYNAKIr7Rkp/OGW7D58iU4DVSud4Y=; b=b4/m2LrXsUwUOsh7cVz7MEsh+I uNboiyHMNPUFnZ3JjKyJKGGaEDGlOxWs6i9SzhxDlurV4LBNe7d6ioCLzgSJE47KyuoIFM6r9/4pB RMhDQmGJAdklqtE3U5Kx0P+kPxFQRpcOsj7fcsK8bXAvCk7aWvE8wMEKIDaSCps33zqS4K+E4DfyL h7JJ7ntadE/zs8P5PPZycmRAsquCY9ZzuC813FsfC5+mTUIn6D8+9e037L+Ws4EoMms156s3TnTmH WWJNgHIP6DZre3sR1ueXv7aAODbfhAz9CiJMwL1yv4R++2iXCFKhwiGH3F48qvIXj/7g8aHLfr0KK CtCcsbiA==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:44008 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lTiiC-001Ijj-V3; Tue, 06 Apr 2021 05:13:32 -0500 Subject: Re: [PATCH][next] iio: hrtimer-trigger: Fix potential integer overflow in iio_hrtimer_store_sampling_frequency To: Jonathan Cameron , "Gustavo A. R. Silva" Cc: Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210329205817.GA188755@embeddedor> <20210405172646.6a9f1b7d@jic23-huawei> From: "Gustavo A. R. Silva" Message-ID: Date: Tue, 6 Apr 2021 05:13:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210405172646.6a9f1b7d@jic23-huawei> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lTiiC-001Ijj-V3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:44008 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/5/21 11:26, Jonathan Cameron wrote: > On Mon, 29 Mar 2021 15:58:17 -0500 > "Gustavo A. R. Silva" wrote: > >> Add suffix ULL to constant 1000 in order to avoid a potential integer >> overflow and give the compiler complete information about the proper >> arithmetic to use. Notice that this constant is being used in a context >> that expects an expression of type unsigned long long, but it's >> currently evaluated using 32-bit arithmetic. >> >> Addresses-Coverity-ID: 1503062 ("Unintentional integer overflow") >> Fixes: dafcf4ed8392 ("iio: hrtimer: Allow sub Hz granularity") >> Signed-off-by: Gustavo A. R. Silva > > Thanks, Applied to the togreg branch of iio.git and pushed out as testing > for 0-day to poke at it. Awesome. :) Thanks, Jonathan. -- Gustavo