From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941629AbcJYKiW (ORCPT ); Tue, 25 Oct 2016 06:38:22 -0400 Received: from foss.arm.com ([217.140.101.70]:44284 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932843AbcJYKiT (ORCPT ); Tue, 25 Oct 2016 06:38:19 -0400 Subject: Re: [PATCH 4/9] pinctrl: meson: allow gpio to request irq To: Linus Walleij , Jerome Brunet References: <1476871709-8359-1-git-send-email-jbrunet@baylibre.com> <1476871709-8359-5-git-send-email-jbrunet@baylibre.com> <1477040798.15560.96.camel@baylibre.com> Cc: Carlo Caione , Kevin Hilman , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Thomas Gleixner , Jason Cooper , Rob Herring , Catalin Marinas , Will Deacon , Russell King From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Tue, 25 Oct 2016 11:38:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/10/16 10:14, Linus Walleij wrote: > On Fri, Oct 21, 2016 at 11:06 AM, Jerome Brunet wrote: > >>> Isn't this usecase (also as described in the cover letter) a textbook >>> example of when you should be using hierarchical irqdomain? >>> >>> Please check with Marc et al on hierarchical irqdomains. >> >> Linus, >> Do you mean I should create a new hierarchical irqdomains in each of >> the two pinctrl instances we have in these SoC, these domains being >> stacked on the one I just added for controller in irqchip ? >> >> I did not understand this is what you meant when I asked you the >> question at ELCE. > > Honestly, I do not understand when and where to properly use > hierarchical irqdomain, even after Marc's talk at ELC-E. I probably didn't do that good a job explaining it then. Let's try again. You want to use hierarchical domains when you want to describe an interrupt whose path traverses multiple controllers without ever being multiplexed with other signals. As long as you have this 1:1 relationship between controllers, you can use them. > Which is problematic since quite a few GPIO drivers now > need to use them. > > I will review his slides, in the meantime I would say: whatever > Marc ACKs is fine with me. I trust this guy 100%. So I guess I > could ask that he ACK the entire chain of patches > from GIC->specialchip->GPIO. Man, I don't even trust myself... ;-) Thanks, M. -- Jazz is not dead. It just smells funny...