From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751209AbdEBCLT (ORCPT <rfc822;w@1wt.eu>);
        Mon, 1 May 2017 22:11:19 -0400
Received: from mga06.intel.com ([134.134.136.31]:57525 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750729AbdEBCLR (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Mon, 1 May 2017 22:11:17 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,402,1488873600"; 
   d="scan'208";a="1142466502"
Subject: Re: [PATCH] perf report: distinguish between inliners in the same
 function
To: Milian Wolff <milian.wolff@kdab.com>, Linux-kernel@vger.kernel.org
Cc: linux-perf-users@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
References: <20170427215950.6649-1-milian.wolff@kdab.com>
From: "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <ec980cd2-f595-3ed5-5276-4d687480e621@linux.intel.com>
Date: Tue, 2 May 2017 10:11:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <20170427215950.6649-1-milian.wolff@kdab.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


SNIP

> ~~~~~
> $ perf report --stdio --inline --no-children
> Failed to open [ext4], continuing without symbols
> # To display the perf.data header info, please use --header/--header-only
> options.
> #
> #
> # Total Lost Samples: 0
> #
> # Samples: 499  of event 'cycles'
> # Event count (approx.): 329354953
> #
> # Overhead  Command    Shared Object      Symbol
> # ........  .........  .................  ................................
> #
>      96.70%  ex_random  ex_random          [.] main
> |
>              ---main
>                 __libc_start_main
>                 _start
> ...
> ~~~~~
>
> Note how no inlined frames are actually shown, because the first
> sample in main points to an IP that does not correspond to any
> inlined frames.

perf report -g address --inline --stdio

Did you try with "-g address" option? It's sorted by address.

But anyway, I like this patch. It works well in my test.

Thanks
Jin Yao