Re: [Freedreno] [PATCH] drm/msm/dsi: Set panel orientation when directly connected

[Abhinav Kumar <quic_abhinavk@quicinc.com>]

Hi Doug

On 8/17/2022 1:48 PM, Doug Anderson wrote:
> Hi,
> 
> On Wed, Jul 20, 2022 at 3:42 PM Doug Anderson <dianders@chromium.org> wrote:
>>
>> Hi,
>>
>> On Wed, Jul 20, 2022 at 1:46 PM Rob Clark <robdclark@gmail.com> wrote:
>>>
>>> On Fri, Jul 8, 2022 at 8:25 AM Doug Anderson <dianders@chromium.org> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd <swboyd@chromium.org> wrote:
>>>>>
>>>>> Set the panel orientation in drm when the panel is directly connected,
>>>>> i.e. we're not using an external bridge. The external bridge case is
>>>>> already handled by the panel bridge code, so we only update the path we
>>>>> take when the panel is directly connected/internal. This silences a
>>>>> warning splat coming from __drm_mode_object_add() on Wormdingler boards.
>>>>>
>>>>> Cc: Hsin-Yi Wang <hsinyi@chromium.org>
>>>>> Cc: Douglas Anderson <dianders@chromium.org>
>>>>> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
>>>>> ---
>>>>>
>>>>> This relies on commit 5e41b01a7808 ("drm/panel: Add an API to allow drm
>>>>> to set orientation from panel") which is in drm-misc
>>>>>
>>>>>   drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 ++
>>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> I don't personally have objections to this, but (to my understanding)
>>>> "the future" is that everyone should use panel_bridge. If we made the
>>>> move to panel_bridge today then we wouldn't need to do this. In
>>>> general I think panel_bridge would end up letting us delete a bunch of
>>>> code...
>>>>
>>>> See commit 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with
>>>> panel-bridge") for when this was done by ti-sn65dsi86.
>>>>
>>>> Then again, I spent a small amount of time looking into this and it's
>>>> definitely non-trivial. Still likely worthwhile, but not worth
>>>> blocking a tiny fix like this. It also should be fairly obvious that
>>>> we should delete this when we switch to panel_bridge.
>>>>
>>>> Thus:
>>>>
>>>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>>>>
>>>> I'll assume that we'll just snooze this commit until drm-misc-next
>>>> merges into a tree that msm-next is based on, which will probably be
>>>> the next -rc1. If desired and Acked I could land this in
>>>> drm-misc-next, but it's probably not worth it?
>>>
>>> if you want to land this patch via drm-misc, which might be the
>>> easier/faster route, then:
>>>
>>> Acked-by: Rob Clark <robdclark@gmail.com>
>>
>> As per discussion on IRC, I'm not going to apply this to drm-misc-next.
>>
>> Given where we are in the cycle landing in drm-misc-next means it
>> won't be in mainline for a couple versions and I suspect that'll cause
>> merge conflicts with Dmitry's series [1]. ...and, of course, if
>> Dmitry's series lands then we don't even need ${SUBJECT} patch...
>>
>> So I think the plan is:
>>
>> 1. Snooze waiting for the next -rc1 since
>> drm_connector_set_orientation_from_panel() won't be in mainline until
>> then.
>>
>> 2. If Dmitry's series looks like a long way off, we could land
>> ${SUBJECT} patch in msm-next as a stopgap fix.
>>
>>
>> [1] https://lore.kernel.org/r/20220711094320.368062-5-dmitry.baryshkov@linaro.org/
> 
> Just checking up. What's the latest thinking here? Do we want to land
> Stephen's change as a stopgap?
> drm_connector_set_orientation_from_panel() is available in v6.0-rc1.
> 
> -Doug

As per todays discussion with Rob on IRC, we will start preparing the 
tree for the next release. So lets drop this one and take the panel 
bridge change instead since my comments on that were minor and can also 
be addressed in a follow up change, will take it up and send it over to 
Rob with some other changes.

Thanks

Abhinav