From: Randy Dunlap <rdunlap@infradead.org>
To: Cai Huoqing <caihuoqing@baidu.com>,
emma@anholt.net, airlied@linux.ie, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/pl111: Remove unused including <linux/version.h>
Date: Tue, 27 Jul 2021 07:29:14 -0700 [thread overview]
Message-ID: <ecafb6ba-ec4f-b98f-c07a-1b03a46a8b71@infradead.org> (raw)
In-Reply-To: <20210727052107.659-1-caihuoqing@baidu.com>
On 7/26/21 10:21 PM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
as reported by 'make versioncheck':
../drivers/gpu/drm/pl111/pl111_display.c: 14 linux/version.h not needed.
../drivers/gpu/drm/pl111/pl111_drv.c: 47 linux/version.h not needed.
> ---
> drivers/gpu/drm/pl111/pl111_display.c | 1 -
> drivers/gpu/drm/pl111/pl111_drv.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index b5a8859739a2..443e3b932322 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -11,7 +11,6 @@
>
> #include <linux/clk.h>
> #include <linux/delay.h>
> -#include <linux/version.h>
> #include <linux/dma-buf.h>
> #include <linux/of_graph.h>
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index fa0a737e9dea..520301b405f1 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -44,7 +44,6 @@
> #include <linux/of_reserved_mem.h>
> #include <linux/shmem_fs.h>
> #include <linux/slab.h>
> -#include <linux/version.h>
>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_bridge.h>
>
thanks.
--
~Randy
prev parent reply other threads:[~2021-07-27 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 5:21 [PATCH] drm/pl111: Remove unused including <linux/version.h> Cai Huoqing
2021-07-27 14:29 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecafb6ba-ec4f-b98f-c07a-1b03a46a8b71@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@linux.ie \
--cc=caihuoqing@baidu.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).