linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	arnd@arndb.de, robh+dt@kernel.org, Marek Vasut <marex@denx.de>,
	jagan@amarulasolutions.com,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Marcin Sloniewski <marcin.sloniewski@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	kuba@kernel.org
Subject: Re: [PATCH 12/13] ARM: dts: stm32: fix DSI port node on STM32MP15
Date: Thu, 15 Apr 2021 12:43:06 +0200	[thread overview]
Message-ID: <ececc78c-4fca-bb93-ef62-5d107501d963@pengutronix.de> (raw)
In-Reply-To: <20210415101037.1465-13-alexandre.torgue@foss.st.com>

Hi,

On 15.04.21 12:10, Alexandre Torgue wrote:
> Running "make dtbs_check W=1", some warnings are reported concerning
> DSI. This patch reorder DSI nodes to avoid:
> 
> soc/dsi@5a000000: unnecessary #address-cells/#size-cells without
> "ranges" or child "reg" property

This reverts parts of commit 9c32f980d9 ("ARM: dts: stm32: preset
stm32mp15x video #address- and #size-cells"):
    
    The cell count for address and size is defined by the binding and not
    something a board would change. Avoid each board adding this
    boilerplate by having the cell size specification in the SoC DTSI.
    

The DSI can have child nodes with a unit address (e.g. a panel) and ones
without (ports { } container). ports is described in the dtsi, panels are
described in the dts if available.

Apparently, the checker is fine with
ports {
	#address-cells = <1>;
	#size-cells = <0>;
};

I think my rationale for the patch above was sound, so I think the checker
taking offense at the DSI cells here should be considered a false positive.

Thanks,
Ahmad

> 
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 
> diff --git a/arch/arm/boot/dts/stm32mp157.dtsi b/arch/arm/boot/dts/stm32mp157.dtsi
> index 54e73ccea446..c355fcf26ec3 100644
> --- a/arch/arm/boot/dts/stm32mp157.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157.dtsi
> @@ -24,8 +24,6 @@
>  			clock-names = "pclk", "ref", "px_clk";
>  			resets = <&rcc DSI_R>;
>  			reset-names = "apb";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			status = "disabled";
>  
>  			ports {
> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts
> index 19ef475a48fc..763dde1dbbaf 100644
> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
> @@ -36,6 +36,8 @@
>  &dsi {
>  	status = "okay";
>  	phy-dsi-supply = <&reg18>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  
>  	ports {
>  		port@0 {
> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> index 6fe5b0fee7c4..4625bb58cc6d 100644
> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> @@ -102,6 +102,8 @@
>  &dsi {
>  	phy-dsi-supply = <&reg18>;
>  	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  
>  	ports {
>  		port@0 {
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2021-04-15 10:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 10:10 [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1 Alexandre Torgue
2021-04-15 10:10 ` [PATCH 01/13] ARM: dts: stm32: fix gpio-keys node on STM32 MCU boards Alexandre Torgue
2021-04-15 10:10 ` [PATCH 02/13] ARM: dts: stm32: fix RCC node name on stm32f429 MCU Alexandre Torgue
2021-04-15 10:10 ` [PATCH 03/13] ARM: dts: stm32: fix timer nodes on STM32 MCU to prevent warnings Alexandre Torgue
2021-04-16 15:52   ` [Linux-stm32] " Fabrice Gasnier
2021-04-15 10:10 ` [PATCH 04/13] dt-bindings: mfd: stm32-timers: remove #address/size cells from required properties Alexandre Torgue
2021-04-16 15:52   ` [Linux-stm32] " Fabrice Gasnier
2021-04-20 20:04   ` Rob Herring
2021-06-01 16:26   ` Lee Jones
2021-04-15 10:10 ` [PATCH 05/13] ARM: dts: stm32: update pinctrl node name on STM32 MCU to prevent warnings Alexandre Torgue
2021-04-15 10:10 ` [PATCH 06/13] ARM: dts: stm32: fix i2c node name on stm32f746 " Alexandre Torgue
2021-04-15 10:10 ` [PATCH 07/13] ARM: dts: stm32: move stmmac axi config in ethernet node on stm32mp15 Alexandre Torgue
2021-04-15 10:10 ` [PATCH 08/13] dt-bindings: net: document ptp_ref clk in dwmac Alexandre Torgue
2021-04-20 20:05   ` Rob Herring
2021-04-15 10:10 ` [PATCH 09/13] ARM: dts: stm32: fix stpmic node for stm32mp1 boards Alexandre Torgue
2021-06-10 14:33   ` Alexandre TORGUE
2021-04-15 10:10 ` [PATCH 10/13] dt-bindings: mfd: add vref_ddr-supply to st,stpmic1 yaml Alexandre Torgue
2021-04-15 10:51   ` Ahmad Fatoum
2021-04-15 12:12     ` Alexandre TORGUE
2021-04-15 10:10 ` [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU Alexandre Torgue
2021-04-15 13:21   ` Marek Vasut
2021-04-15 13:34     ` Alexandre TORGUE
2021-04-15 14:30       ` Marek Vasut
2021-04-15 14:35         ` Alexandre TORGUE
2021-04-15 14:59           ` Marek Vasut
2021-04-15 10:10 ` [PATCH 12/13] ARM: dts: stm32: fix DSI port node on STM32MP15 Alexandre Torgue
2021-04-15 10:43   ` Ahmad Fatoum [this message]
2021-04-15 12:23     ` Alexandre TORGUE
2021-04-19 13:57       ` Arnd Bergmann
2021-04-19 14:04         ` Alexandre TORGUE
2021-05-04 13:16         ` Ahmad Fatoum
2021-04-15 10:10 ` [PATCH 13/13] ARM: dts: stm32: fix ltdc pinctrl on microdev2.0-of7 Alexandre Torgue
2021-06-01 10:37 ` [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1 Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ececc78c-4fca-bb93-ef62-5d107501d963@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jagan@amarulasolutions.com \
    --cc=kuba@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=marcin.sloniewski@gmail.com \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).