From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71CEC43461 for ; Thu, 15 Apr 2021 10:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A82D760C41 for ; Thu, 15 Apr 2021 10:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbhDOKnf (ORCPT ); Thu, 15 Apr 2021 06:43:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbhDOKne (ORCPT ); Thu, 15 Apr 2021 06:43:34 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 617F8C061574 for ; Thu, 15 Apr 2021 03:43:11 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lWzSn-0005Vb-Hb; Thu, 15 Apr 2021 12:43:09 +0200 Subject: Re: [PATCH 12/13] ARM: dts: stm32: fix DSI port node on STM32MP15 To: Alexandre Torgue , arnd@arndb.de, robh+dt@kernel.org, Marek Vasut , jagan@amarulasolutions.com, Manivannan Sadhasivam , Marcin Sloniewski Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, Lee Jones , kuba@kernel.org References: <20210415101037.1465-1-alexandre.torgue@foss.st.com> <20210415101037.1465-13-alexandre.torgue@foss.st.com> From: Ahmad Fatoum Message-ID: Date: Thu, 15 Apr 2021 12:43:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210415101037.1465-13-alexandre.torgue@foss.st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 15.04.21 12:10, Alexandre Torgue wrote: > Running "make dtbs_check W=1", some warnings are reported concerning > DSI. This patch reorder DSI nodes to avoid: > > soc/dsi@5a000000: unnecessary #address-cells/#size-cells without > "ranges" or child "reg" property This reverts parts of commit 9c32f980d9 ("ARM: dts: stm32: preset stm32mp15x video #address- and #size-cells"): The cell count for address and size is defined by the binding and not something a board would change. Avoid each board adding this boilerplate by having the cell size specification in the SoC DTSI. The DSI can have child nodes with a unit address (e.g. a panel) and ones without (ports { } container). ports is described in the dtsi, panels are described in the dts if available. Apparently, the checker is fine with ports { #address-cells = <1>; #size-cells = <0>; }; I think my rationale for the patch above was sound, so I think the checker taking offense at the DSI cells here should be considered a false positive. Thanks, Ahmad > > Signed-off-by: Alexandre Torgue > > diff --git a/arch/arm/boot/dts/stm32mp157.dtsi b/arch/arm/boot/dts/stm32mp157.dtsi > index 54e73ccea446..c355fcf26ec3 100644 > --- a/arch/arm/boot/dts/stm32mp157.dtsi > +++ b/arch/arm/boot/dts/stm32mp157.dtsi > @@ -24,8 +24,6 @@ > clock-names = "pclk", "ref", "px_clk"; > resets = <&rcc DSI_R>; > reset-names = "apb"; > - #address-cells = <1>; > - #size-cells = <0>; > status = "disabled"; > > ports { > diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts > index 19ef475a48fc..763dde1dbbaf 100644 > --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts > +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts > @@ -36,6 +36,8 @@ > &dsi { > status = "okay"; > phy-dsi-supply = <®18>; > + #address-cells = <1>; > + #size-cells = <0>; > > ports { > port@0 { > diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts > index 6fe5b0fee7c4..4625bb58cc6d 100644 > --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts > +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts > @@ -102,6 +102,8 @@ > &dsi { > phy-dsi-supply = <®18>; > status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > > ports { > port@0 { > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |