From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0
Date: Tue, 7 Sep 2021 12:09:12 +0200 [thread overview]
Message-ID: <ecf17c7b-09a4-29a7-6951-1e0b0dda3c67@suse.com> (raw)
In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com>
The xen_hvm_early_write() path better wouldn't be taken in this case;
while port 0xE9 can be used, the hypercall path is quite a bit more
efficient. Put that first, as it may also work for DomU-s (see also
xen_raw_console_write()).
While there also bail from the function when the first
domU_write_console() failed - later ones aren't going to succeed.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -632,17 +632,16 @@ static void xenboot_write_console(struct
unsigned int linelen, off = 0;
const char *pos;
+ if (dom0_write_console(0, string, len) >= 0)
+ return;
+
if (!xen_pv_domain()) {
xen_hvm_early_write(0, string, len);
return;
}
- dom0_write_console(0, string, len);
-
- if (xen_initial_domain())
+ if (domU_write_console(0, "(early) ", 8) < 0)
return;
-
- domU_write_console(0, "(early) ", 8);
while (off < len && NULL != (pos = strchr(string+off, '\n'))) {
linelen = pos-string+off;
if (off + linelen > len)
next prev parent reply other threads:[~2021-09-07 10:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 10:04 [PATCH 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments Jan Beulich
2021-09-07 10:07 ` [PATCH 1/9] xen/x86: prevent PVH type from getting clobbered Jan Beulich
2021-09-23 13:06 ` Juergen Gross
2021-09-07 10:08 ` [PATCH 2/9] xen/x86: allow PVH Dom0 without XEN_PV=y Jan Beulich
2021-09-23 14:03 ` Juergen Gross
2021-09-07 10:09 ` Jan Beulich [this message]
2021-09-23 14:05 ` [PATCH 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0 Juergen Gross
2021-09-07 10:09 ` [PATCH 4/9] xen/x86: allow "earlyprintk=xen" to work for PV Dom0 Jan Beulich
2021-09-23 14:06 ` Juergen Gross
2021-09-07 10:10 ` [PATCH 5/9] xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU Jan Beulich
2021-09-23 14:08 ` Juergen Gross
2021-09-07 10:10 ` [PATCH 6/9] xen/x86: generalize preferred console model from PV to PVH Dom0 Jan Beulich
2021-09-23 14:54 ` Juergen Gross
2021-09-07 10:11 ` [PATCH 7/9] xen/x86: hook up xen_banner() also for PVH Jan Beulich
2021-09-23 14:59 ` Juergen Gross
2021-09-23 15:10 ` Jan Beulich
2021-09-23 15:15 ` Juergen Gross
2021-09-23 15:19 ` Jan Beulich
2021-09-23 15:25 ` Juergen Gross
2021-09-23 15:31 ` Jan Beulich
2021-09-29 5:45 ` Juergen Gross
2021-09-29 7:28 ` Jan Beulich
2021-09-29 7:29 ` Juergen Gross
2021-09-07 10:12 ` [PATCH 8/9] x86/PVH: adjust function/data placement Jan Beulich
2021-09-23 15:02 ` Juergen Gross
2021-09-07 10:13 ` [PATCH 9/9] xen/x86: adjust data placement Jan Beulich
2021-09-23 15:04 ` Juergen Gross
2021-09-14 8:32 ` [PATCH 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments Roger Pau Monné
2021-09-14 9:03 ` Jan Beulich
2021-09-14 11:15 ` Roger Pau Monné
2021-09-14 11:58 ` Jan Beulich
2021-09-14 12:41 ` Roger Pau Monné
2021-09-14 15:13 ` Jan Beulich
2021-09-14 16:27 ` Roger Pau Monné
2021-09-15 8:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecf17c7b-09a4-29a7-6951-1e0b0dda3c67@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).