linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Sumit Semwal <sumit.semwal@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	yudongbin@hisilicon.com, Chen Feng <puck.chen@hisilicon.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	kernel@stlinux.com
Subject: Re: [PATCH 0/3] add ION driver for STIh4xx SoC
Date: Wed, 26 Oct 2016 16:25:57 -0700	[thread overview]
Message-ID: <ecf45666-33e0-0f08-796d-3d7587fefd52@redhat.com> (raw)
In-Reply-To: <CA+M3ks47jK5-szSBgwZ-mpBZcSCSCeCZ9GinDKCiDU+2E5SdhA@mail.gmail.com>

On 10/26/2016 08:05 AM, Benjamin Gaignard wrote:
> 2016-10-26 16:44 GMT+02:00 Sumit Semwal <sumit.semwal@linaro.org>:
>> On 26 October 2016 at 20:11, Benjamin Gaignard
>> <benjamin.gaignard@linaro.org> wrote:
>>> 2016-10-26 15:51 GMT+02:00 Sumit Semwal <sumit.semwal@linaro.org>:
>>>> Hello Benjamin,
>>>>
>>>> On 26 October 2016 at 19:02, Benjamin Gaignard
>>>> <benjamin.gaignard@linaro.org> wrote:
>>>>> It is more or less a copy of Hisilicon driver but with a heap definition
>>>>> fitting with STIH4xx SoC needs.
>>>>> I have just chnage the some function prefix from "hi6220" to "sti".
>>>>>
>>>> Thanks for your patches!
>>>>
>>>> I was just wondering if you couldn't convert the HiSilicon driver into
>>>> something like a 'simple-ion' driver, and have just the DT definitions
>>>> as specifics? This would save a lot of code duplication, and keep it
>>>> as a simple interface for common heaps like cma.
>>>
>>> Create a simple-ion driver is a good idea but it means that heaps
>>> (configuration, name, etc..)
>>> will have to be describe into devicetree. I'm not sure if that will is
>>> acceptable.
>>>
>>>>
>>>> If there are any ST-specific requirements that are incompatible with
>>>> the existing driver, it should be clearly documented out here I think.
>>>
>>> heaps names and Ids aren't the same so I can't reuse hisilicon driver.
>>>
>> But I'd suspect both these are solvable with using something like
>> 'generic,cma' instead of 'hisi,cma' or 'st,cma'?
>
> yes, but it requires to describe the heaps in devicetree.
> Hisilicon driver was doing like that until last month but Laura
> convert it to common platform:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/staging/android/ion/hisilicon?id=b6e336dbeda85585c3ba6d935753d8240e18baf1
>
> I bet she got good reasons do to that so I have implemented sti ION
> driver in this mindset.
>

I agree that having common code would be useful. There are some
generic bindings listed in drivers/staging/android/ion/devicetree.txt
so we could go with linux,ion-heap-dma.

The changes got merged and there were never mailing list objections
but that's because the devicetree maintainers got busy and never
actually looked at them and Arnd at least still didn't like the
idea of Ion in devicetree. I'd like to wait until after plumbers
next week to decide what to do.



>>>
>> Best,
>> Sumit.
>
>
>

Thanks,
Laura

  reply	other threads:[~2016-10-26 23:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 13:32 Benjamin Gaignard
2016-10-26 13:32 ` [PATCH 1/3] add binding for STIh4xx ION driver Benjamin Gaignard
2016-10-26 13:32 ` [PATCH 2/3] add STIH4xx " Benjamin Gaignard
2016-10-26 13:32 ` [PATCH 3/3] add STIH4xx ION driver in DT Benjamin Gaignard
2016-10-26 13:51 ` [PATCH 0/3] add ION driver for STIh4xx SoC Sumit Semwal
2016-10-26 14:41   ` Benjamin Gaignard
2016-10-26 14:44     ` Sumit Semwal
2016-10-26 15:05       ` Benjamin Gaignard
2016-10-26 23:25         ` Laura Abbott [this message]
2016-11-07 10:17           ` Benjamin Gaignard
2016-11-07 22:17             ` Laura Abbott
2016-11-08  9:18               ` Benjamin Gaignard
2016-11-09  4:49                 ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecf45666-33e0-0f08-796d-3d7587fefd52@redhat.com \
    --to=labbott@redhat.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@stlinux.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puck.chen@hisilicon.com \
    --cc=sumit.semwal@linaro.org \
    --cc=yudongbin@hisilicon.com \
    --subject='Re: [PATCH 0/3] add ION driver for STIh4xx SoC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).