From: Gal Pressman <galpress@amazon.com>
To: "Christian König" <christian.koenig@amd.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Doug Ledford" <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>
Cc: <linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
Oded Gabbay <ogabbay@habana.ai>, Tomer Tayar <ttayar@habana.ai>,
Yossi Leybovich <sleybo@amazon.com>,
Alexander Matushevsky <matua@amazon.com>,
Leon Romanovsky <leonro@nvidia.com>,
Jianxin Xiong <jianxin.xiong@intel.com>,
Firas Jahjah <firasj@amazon.com>
Subject: Re: [RFC PATCH 1/2] dma-buf: Fix pin callback comment
Date: Sun, 10 Oct 2021 09:50:23 +0300 [thread overview]
Message-ID: <ed04e512-ffad-58c8-4e8b-83c6b6099f0f@amazon.com> (raw)
In-Reply-To: <747d423e-9073-9bed-778a-292e47adf0f6@amd.com>
On 07/10/2021 13:44, Christian König wrote:
> Am 07.10.21 um 12:42 schrieb Gal Pressman:
>> The pin callback does not necessarily have to move the memory to system
>> memory, remove the sentence from the comment.
>>
>> Signed-off-by: Gal Pressman <galpress@amazon.com>
>> ---
>> include/linux/dma-buf.h | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
>> index efdc56b9d95f..93830731a9a3 100644
>> --- a/include/linux/dma-buf.h
>> +++ b/include/linux/dma-buf.h
>> @@ -86,9 +86,7 @@ struct dma_buf_ops {
>> * @pin:
>> *
>> * This is called by dma_buf_pin() and lets the exporter know that the
>> - * DMA-buf can't be moved any more. The exporter should pin the buffer
>> - * into system memory to make sure it is generally accessible by other
>> - * devices.
>
> Maybe change that to something like "Ideally the exporter should pin the buffer
> so that it is generally accessible by all devices".
Sure, thanks.
next prev parent reply other threads:[~2021-10-10 6:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 10:42 [RFC PATCH 0/2] EFA dmabuf memory regions Gal Pressman
2021-10-07 10:42 ` [RFC PATCH 1/2] dma-buf: Fix pin callback comment Gal Pressman
2021-10-07 10:44 ` Christian König
2021-10-10 6:50 ` Gal Pressman [this message]
2021-10-07 10:43 ` [RFC PATCH 2/2] RDMA/efa: Add support for dmabuf memory regions Gal Pressman
2021-10-07 11:40 ` Jason Gunthorpe
2021-10-10 6:55 ` Gal Pressman
2021-10-11 23:28 ` Jason Gunthorpe
2021-10-12 11:41 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed04e512-ffad-58c8-4e8b-83c6b6099f0f@amazon.com \
--to=galpress@amazon.com \
--cc=christian.koenig@amd.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=firasj@amazon.com \
--cc=jgg@ziepe.ca \
--cc=jianxin.xiong@intel.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=ogabbay@habana.ai \
--cc=sleybo@amazon.com \
--cc=sumit.semwal@linaro.org \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).