From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: Do not leak kernel stack data in the KVM_S390_INTERRUPT ioctl
Date: Fri, 13 Sep 2019 09:34:34 +0200 [thread overview]
Message-ID: <ed0cf9eb-e3dc-f8d5-1eea-9034e5c0498d@redhat.com> (raw)
In-Reply-To: <20190913092030.373a9254.cohuck@redhat.com>
On 13/09/2019 09.20, Cornelia Huck wrote:
> On Thu, 12 Sep 2019 13:23:38 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> Hmm, we already talked about deprecating support for pre-3.15 kernel
>> stuff in the past (see
>> https://wiki.qemu.org/ChangeLog/2.12#Future_incompatible_changes for
>> example),
>
> Btw: did we ever do that? I don't quite recall what code we were
> talking about...
We never really did - but we also never fixed the issue: If you run the
current QEMU on a kernel before 3.15, it refuses to work due to the
missing in-kernel FLIC device:
Initialization of device s390-flic-kvm failed: KVM is missing capability
KVM_CAP_DEVICE_CTR
Since nobody really complained so far that running QEMU with KVM is
still required on a kernel < 3.15, I think we could make this also
"official" now and improve the error message a little bit, pointing the
user to a kernel >= 3.15.
Thomas
next prev parent reply other threads:[~2019-09-13 7:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 9:00 [PATCH] KVM: s390: Do not leak kernel stack data in the KVM_S390_INTERRUPT ioctl Thomas Huth
2019-09-12 9:14 ` David Hildenbrand
2019-09-12 9:20 ` Thomas Huth
2019-09-12 9:28 ` Janosch Frank
2019-09-12 10:52 ` Christian Borntraeger
2019-09-12 11:23 ` Thomas Huth
2019-09-13 7:20 ` Cornelia Huck
2019-09-13 7:34 ` Thomas Huth [this message]
2019-09-13 7:37 ` David Hildenbrand
2019-09-13 7:43 ` Thomas Huth
2019-09-13 7:47 ` David Hildenbrand
2019-09-12 10:58 ` David Hildenbrand
2019-09-12 11:00 ` Christian Borntraeger
2019-09-12 10:47 ` Christian Borntraeger
2019-09-12 11:08 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0cf9eb-e3dc-f8d5-1eea-9034e5c0498d@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).