From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0278C433EF for ; Thu, 30 Dec 2021 06:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236627AbhL3Gn2 (ORCPT ); Thu, 30 Dec 2021 01:43:28 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:59162 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbhL3Gn0 (ORCPT ); Thu, 30 Dec 2021 01:43:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA274B819C4 for ; Thu, 30 Dec 2021 06:43:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 696A2C36AEA; Thu, 30 Dec 2021 06:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640846603; bh=Y7MIC/xYNj2vm5NGLwlLkT0zp8qCJy3s2XKulDkACpg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z8Xqh78JTQp6jVO3NAkEcsB5frk7x+kGgJxt5knRMUlkVcGwSwq4rmoM1Fyy8npbQ VTwmWWucwzOKCzdp9U+oTF4izVKlFquQtoGUgGOn+C+ehsK3iP0/UxwMSsL0FJmX2p hSdjmNyy5RHxo0cdYLowthxTuUQV8tecPG/gBU2VtRYHiIrDO+K1RE2RUtGxvR4fiC 8wzhsWHsEfrE3BcJXh+zfAtRCRt8yVS5o2/nkKlERBG0vGjt+ywUhqsct4mpp9TYOj jamG3QVfVgiNrXmpC3iTAd6YKigALIhjj9gz4WryKZ5tRfUyGXbzv/uTyDevjgjnaS 8qyF3aIB8ZSvQ== Message-ID: Date: Thu, 30 Dec 2021 14:43:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Content-Language: en-US To: Jaegeuk Kim , Eric Biggers Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-5-jaegeuk@kernel.org> <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/12/3 5:28, Jaegeuk Kim wrote: > On 12/02, Jaegeuk Kim wrote: >> On 12/02, Eric Biggers wrote: >>> On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: >>>> On 12/02, Jaegeuk Kim wrote: >>>>> On 12/02, Eric Biggers wrote: >>>>>> On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: >>>>>>> On 2021/12/2 12:15, Eric Biggers wrote: >>>>>>>> On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: >>>>>>>>> Why not relocating this check before f2fs_map_blocks()? >>>>>>> >>>>>>> Wait, it supports DIO in multi-device image after commit 71f2c8206202 >>>>>>> ("f2fs: multidevice: support direct IO"), how about >>>>>>> checking with f2fs_allow_multi_device_dio()? >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>> >>>>>> Okay, that was not the case when I sent this patch originally. We'll need to >>>>>> update this to support multiple devices. >>>>> >>>>> Chao/Eric, does this make sense? >>>>> >>>>> --- a/fs/f2fs/data.c >>>>> +++ b/fs/f2fs/data.c >>>>> @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, >>>>> } >>>>> if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk))) >>>>> return -EINVAL; >>>>> - iomap->addr = blks_to_bytes(inode, map.m_pblk); >>>>> >>>>> - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode)))) >>>>> - return -EINVAL; >>>>> - iomap->bdev = inode->i_sb->s_bdev; >>>>> + iomap->bdev = map->m_multidev_dio ? map.m_bdev : >>>> >>>> correction: map.m_multidev_dio >>>> >>> >>> I guess so, but why doesn't f2fs_map_blocks() just always set m_bdev to the >>> correct block device? What is the point of m_multidev_dio? >> >> It seems we can simply assign iomap->bdev = map.m_bdev, and remove >> map->m_multidev_dio. > > Ok, it was used in previous get_block flow, but I think it'd be worth to keep it > to show by f2fs_map_blocks tracepoint. The last version wasn't sent into mailing list? Thanks, > >> >>> >>> - Eric >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel