From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbdJSThZ (ORCPT ); Thu, 19 Oct 2017 15:37:25 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:59267 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752913AbdJSThX (ORCPT ); Thu, 19 Oct 2017 15:37:23 -0400 Subject: Re: [PATCH] perf parser: Improve error message for PMU address filters To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Andi Kleen , Taeung Song , Mathieu Poirier , linux-kernel@vger.kernel.org References: <20170905090839.1619-1-jackdev@mailbox.org> From: Jack Henschel Message-ID: Date: Thu, 19 Oct 2017 21:37:13 +0200 MIME-Version: 1.0 In-Reply-To: <20170905090839.1619-1-jackdev@mailbox.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EII2xnkWSgXPKO2r1a1NExIIiPR9x4htr" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EII2xnkWSgXPKO2r1a1NExIIiPR9x4htr Content-Type: multipart/mixed; boundary="sIr6hMkCDv08amqSNDGgHdsPSLECEpD4v"; protected-headers="v1" From: Jack Henschel To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Andi Kleen , Taeung Song , Mathieu Poirier , linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] perf parser: Improve error message for PMU address filters References: <20170905090839.1619-1-jackdev@mailbox.org> In-Reply-To: <20170905090839.1619-1-jackdev@mailbox.org> --sIr6hMkCDv08amqSNDGgHdsPSLECEpD4v Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 09/05/2017 11:08 AM, Jack Henschel wrote: > This patch improves the error message of the perf events parser > when the PMU hardware does not support address filters. >=20 > Previously, the perf returned the following error: >> --filter option should follow a -e tracepoint or HW tracer option > This implies there is some syntax error present in the command line, > which is not true. Rather, notify the user that the CPU does not have > support for this feature. >=20 > For example, Intel chips based on the Broadwell micro-archticture have > the Intel PT PMU, but do not support address filtering. >=20 > Signed-off-by: Jack Henschel > --- > tools/perf/util/parse-events.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-eve= nts.c > index f44aeba51d1f..672b6d9423e9 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1833,8 +1833,11 @@ static int set_filter(struct perf_evsel *evsel, = const void *arg) > int nr_addr_filters =3D 0; > struct perf_pmu *pmu =3D NULL; > =20 > - if (evsel =3D=3D NULL) > - goto err; > + if (evsel =3D=3D NULL) { > + fprintf(stderr, > + "--filter option should follow a -e tracepoint or HW tracer option\= n"); > + return -1; > + } > =20 > if (evsel->attr.type =3D=3D PERF_TYPE_TRACEPOINT) { > if (perf_evsel__append_tp_filter(evsel, str) < 0) { > @@ -1856,8 +1859,11 @@ static int set_filter(struct perf_evsel *evsel, = const void *arg) > perf_pmu__scan_file(pmu, "nr_addr_filters", > "%d", &nr_addr_filters); > =20 > - if (!nr_addr_filters) > - goto err; > + if (!nr_addr_filters) { > + fprintf(stderr, > + "This CPU does not support address filtering\n"); > + return -1; > + } > =20 > if (perf_evsel__append_addr_filter(evsel, str) < 0) { > fprintf(stderr, > @@ -1866,12 +1872,6 @@ static int set_filter(struct perf_evsel *evsel, = const void *arg) > } > =20 > return 0; > - > -err: > - fprintf(stderr, > - "--filter option should follow a -e tracepoint or HW tracer option\n= "); > - > - return -1; > } > =20 > int parse_filter(const struct option *opt, const char *str, >=20 Is there any interest in this patch? Did it get lost? Greetings Jack --sIr6hMkCDv08amqSNDGgHdsPSLECEpD4v-- --EII2xnkWSgXPKO2r1a1NExIIiPR9x4htr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEE5SNfW5QVort2C78YV5HQ+s4K8DwFAlno/u0UHGphY2tkZXZA bWFpbGJveC5vcmcACgkQV5HQ+s4K8DzBXw/9Eff/Bz0MzM8dy0WoBzeHPE33fZZU vfsRvEN1MiWCPnaPrX2MEBAjgJCy6vlME6CRW8OSoRHS4JdeJKXp5fo6Rr5HpTYn RUGpgmJwwBAHSzsWg4sAY6wvLKMfmo/4XuY3t59lZKL9FvrAqp0HM/zsPWnVDh1Y P2JBAtfKm1zHjmFRbiNnppaOJFX0P/+bTh8ISTtGu1fBP8XRyMNlA7GNM2UHRRcX B1kzq2NL6u8r5Aa3jZkOBz84BcHrmjGmSQMB5q47xx8/CpXPvPmmETxmSV45ssAz oajl0Eb6DBOxHp09XNr01l+SAL40Y9pXEXIf8Y0lYS5TjWU8ompld/GRMtYCmPNQ Y6nzvObO8Get44ckrJzJt8ElZma+Aw+aI/5C9O4qvA1/DHjxs14C5oeAGcfgr/qi MiRRqNBfQGRqE26AUnIe3gtCENrZnw6559TaePljt9MfAerf3RK02kHXNQ0cfE2e ER91Ou0bL2i7cJacV9Y6AWVnrgAMl/rA14HkweoS9DU16BQbMld5UQju/XfZm5Nf AVOyBI79ldvrSDTU2zI7ny9TfeoK/O6EVn8IhQu62xdhcnbQR5TEX+IfndnFpeGM eLcbEd/oScB+75lndE9b8BMg9uVdktjwF3nkOgoVBwL9zvCE3sMS8iYGe+FScetE HOjxOIYF+lAOdME= =UbBG -----END PGP SIGNATURE----- --EII2xnkWSgXPKO2r1a1NExIIiPR9x4htr--