From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC229C433DB for ; Fri, 5 Feb 2021 16:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7244764DB1 for ; Fri, 5 Feb 2021 16:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbhBEOlq (ORCPT ); Fri, 5 Feb 2021 09:41:46 -0500 Received: from mga09.intel.com ([134.134.136.24]:4778 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232766AbhBEOhh (ORCPT ); Fri, 5 Feb 2021 09:37:37 -0500 IronPort-SDR: wjxYUgnMWqf1ArrZ4LZT/msnNwj0GLEIskhMXtJlEU+9MncFvbvnTvhDUSNtE3MLVR4xJT/tEy yQ/V2OoeDYCA== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="181600524" X-IronPort-AV: E=Sophos;i="5.81,155,1610438400"; d="scan'208";a="181600524" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 08:15:04 -0800 IronPort-SDR: akZdZKUTioYDCFVHHy7cAMfgbH73YlLAuL7TEXfol7Nx3sovkJgDAGcc/VFRw85sHwb0MKm2y6 7ZcStecAUDNw== X-IronPort-AV: E=Sophos;i="5.81,155,1610438400"; d="scan'208";a="583829114" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.212.95.7]) ([10.212.95.7]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 08:15:03 -0800 Subject: Re: [PATCH v19 04/25] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu References: <20210203225547.32221-1-yu-cheng.yu@intel.com> <20210203225547.32221-5-yu-cheng.yu@intel.com> <20210205134305.GG17488@zn.tnic> From: "Yu, Yu-cheng" Message-ID: Date: Fri, 5 Feb 2021 08:15:02 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210205134305.GG17488@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/5/2021 5:43 AM, Borislav Petkov wrote: > On Wed, Feb 03, 2021 at 02:55:26PM -0800, Yu-cheng Yu wrote: >> @@ -1252,6 +1260,13 @@ static void __init cpu_parse_early_param(void) >> if (cmdline_find_option_bool(boot_command_line, "noxsaves")) >> setup_clear_cpu_cap(X86_FEATURE_XSAVES); >> >> +#ifdef CONFIG_X86_CET >> + if (cmdline_find_option_bool(boot_command_line, "no_user_shstk")) >> + setup_clear_cpu_cap(X86_FEATURE_SHSTK); >> + if (cmdline_find_option_bool(boot_command_line, "no_user_ibt")) >> + setup_clear_cpu_cap(X86_FEATURE_IBT); >> +#endif > > Any particular need for the ifdeffery? > Right. There is no need for that. I will remove it. -- Yu-cheng