From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Nitesh Narayan Lal <nitesh@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
kvm@vger.kernel.org, david@redhat.com, mst@redhat.com,
dave.hansen@intel.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: yang.zhang.wz@gmail.com, pagupta@redhat.com, riel@surriel.com,
konrad.wilk@oracle.com, willy@infradead.org,
lcapitulino@redhat.com, wei.w.wang@intel.com,
aarcange@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com
Subject: Re: [PATCH v3 6/6] virtio-balloon: Add support for providing unused page reports to host
Date: Mon, 05 Aug 2019 09:27:16 -0700 [thread overview]
Message-ID: <ed48ecdb833808bf6b08bc54fa98503cbad493f3.camel@linux.intel.com> (raw)
In-Reply-To: <1cff09a4-d302-639c-ab08-9d82e5fc1383@redhat.com>
On Mon, 2019-08-05 at 12:00 -0400, Nitesh Narayan Lal wrote:
> On 8/1/19 6:38 PM, Alexander Duyck wrote:
> > From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> >
> > Add support for the page reporting feature provided by virtio-balloon.
> > Reporting differs from the regular balloon functionality in that is is
> > much less durable than a standard memory balloon. Instead of creating a
> > list of pages that cannot be accessed the pages are only inaccessible
> > while they are being indicated to the virtio interface. Once the
> > interface has acknowledged them they are placed back into their respective
> > free lists and are once again accessible by the guest system.
> >
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > ---
> > drivers/virtio/Kconfig | 1 +
> > drivers/virtio/virtio_balloon.c | 56 +++++++++++++++++++++++++++++++++++
> > include/uapi/linux/virtio_balloon.h | 1 +
> > 3 files changed, 58 insertions(+)
> >
> > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > index 078615cf2afc..4b2dd8259ff5 100644
> > --- a/drivers/virtio/Kconfig
> > +++ b/drivers/virtio/Kconfig
> > @@ -58,6 +58,7 @@ config VIRTIO_BALLOON
> > tristate "Virtio balloon driver"
> > depends on VIRTIO
> > select MEMORY_BALLOON
> > + select PAGE_REPORTING
> > ---help---
> > This driver supports increasing and decreasing the amount
> > of memory within a KVM guest.
> > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> > index 2c19457ab573..971fe924e34f 100644
> > --- a/drivers/virtio/virtio_balloon.c
> > +++ b/drivers/virtio/virtio_balloon.c
> > @@ -19,6 +19,7 @@
> > #include <linux/mount.h>
> > #include <linux/magic.h>
> > #include <linux/pseudo_fs.h>
> > +#include <linux/page_reporting.h>
> >
> > /*
> > * Balloon device works in 4K page units. So each page is pointed to by
> > @@ -37,6 +38,9 @@
> > #define VIRTIO_BALLOON_FREE_PAGE_SIZE \
> > (1 << (VIRTIO_BALLOON_FREE_PAGE_ORDER + PAGE_SHIFT))
> >
> > +/* limit on the number of pages that can be on the reporting vq */
> > +#define VIRTIO_BALLOON_VRING_HINTS_MAX 16
> > +
> > #ifdef CONFIG_BALLOON_COMPACTION
> > static struct vfsmount *balloon_mnt;
> > #endif
> > @@ -46,6 +50,7 @@ enum virtio_balloon_vq {
> > VIRTIO_BALLOON_VQ_DEFLATE,
> > VIRTIO_BALLOON_VQ_STATS,
> > VIRTIO_BALLOON_VQ_FREE_PAGE,
> > + VIRTIO_BALLOON_VQ_REPORTING,
> > VIRTIO_BALLOON_VQ_MAX
> > };
> >
> > @@ -113,6 +118,10 @@ struct virtio_balloon {
> >
> > /* To register a shrinker to shrink memory upon memory pressure */
> > struct shrinker shrinker;
> > +
> > + /* Unused page reporting device */
> > + struct virtqueue *reporting_vq;
> > + struct page_reporting_dev_info ph_dev_info;
> > };
> >
> > static struct virtio_device_id id_table[] = {
> > @@ -152,6 +161,23 @@ static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq)
> >
> > }
> >
> > +void virtballoon_unused_page_report(struct page_reporting_dev_info *ph_dev_info,
> > + unsigned int nents)
> > +{
> > + struct virtio_balloon *vb =
> > + container_of(ph_dev_info, struct virtio_balloon, ph_dev_info);
> > + struct virtqueue *vq = vb->reporting_vq;
> > + unsigned int unused;
> > +
> > + /* We should always be able to add these buffers to an empty queue. */
> > + virtqueue_add_inbuf(vq, ph_dev_info->sg, nents, vb,
> > + GFP_NOWAIT | __GFP_NOWARN);
>
> I think you should handle allocation failure here. It is a possibility, isn't?
> Maybe return an error or even disable page hinting/reporting?
>
I don't think it is an issue I have to worry about. Specifically I am
limiting the size of the scatterlist based on the size of the vq. As such
I will never exceed the size and should be able to use it to store the
scatterlist directly.
next prev parent reply other threads:[~2019-08-05 16:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 22:24 [PATCH v3 0/6] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-08-01 22:27 ` [PATCH v3 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-08-01 22:29 ` [PATCH v3 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-08-01 22:31 ` [PATCH v3 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-08-01 22:33 ` [PATCH v3 4/6] mm: Introduce Reported pages Alexander Duyck
2019-08-05 14:05 ` Nitesh Narayan Lal
2019-08-05 15:11 ` Alexander Duyck
2019-08-01 22:36 ` [PATCH v3 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-08-01 22:38 ` [PATCH v3 6/6] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-08-05 16:00 ` Nitesh Narayan Lal
2019-08-05 16:27 ` Alexander Duyck [this message]
2019-08-06 11:31 ` Michael S. Tsirkin
2019-08-06 15:16 ` Alexander Duyck
2019-08-06 15:40 ` Nitesh Narayan Lal
2019-08-01 22:41 ` [PATCH v3 QEMU 1/2] virtio-ballon: Implement support for page poison tracking feature Alexander Duyck
2019-08-01 22:43 ` [PATCH v3 QEMU 2/2] virtio-balloon: Provide a interface for unused page reporting Alexander Duyck
2019-08-02 20:40 ` Nitesh Narayan Lal
2019-08-02 20:58 ` Alexander Duyck
2019-08-02 14:41 ` [PATCH v3 0/6] mm / virtio: Provide support " Nitesh Narayan Lal
2019-08-02 15:13 ` Alexander Duyck
2019-08-02 16:19 ` Nitesh Narayan Lal
2019-08-02 17:28 ` Alexander Duyck
2019-08-02 23:15 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed48ecdb833808bf6b08bc54fa98503cbad493f3.camel@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=wei.w.wang@intel.com \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).