From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F110C433E0 for ; Tue, 12 Jan 2021 21:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D285621534 for ; Tue, 12 Jan 2021 21:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437470AbhALVe1 (ORCPT ); Tue, 12 Jan 2021 16:34:27 -0500 Received: from mga09.intel.com ([134.134.136.24]:13240 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436839AbhALUSz (ORCPT ); Tue, 12 Jan 2021 15:18:55 -0500 IronPort-SDR: u491VDRj4HXfcFgT8yXG92iAok2Br31hugqFxQgzKmFgo3d0cyOLb+BNAI0yQCa1UappsbfjT2 jwnNzJjOsFrA== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="178250782" X-IronPort-AV: E=Sophos;i="5.79,342,1602572400"; d="scan'208";a="178250782" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 12:17:10 -0800 IronPort-SDR: 29Hbz6FgfIXaFdwmqBXeJT+DW03oBkD+FjOq44WsfUZaY9DMsF/rZx4feKfuCJmvFQIxRlIBdF fVgvRuqyFHJg== X-IronPort-AV: E=Sophos;i="5.79,342,1602572400"; d="scan'208";a="404593879" Received: from clinton1-mobl1.amr.corp.intel.com (HELO [10.212.214.129]) ([10.212.214.129]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 12:17:08 -0800 Subject: Re: [Sound-open-firmware] [PATCH] ASoC: SOF: Intel: avoid reverse module dependency To: Takashi Iwai Cc: Arnd Bergmann , ALSA Development Mailing List , Kai Vehmanen , Arnd Bergmann , "linux-kernel @ vger . kernel . org" , Takashi Iwai , YueHaibing , Liam Girdwood , Jaroslav Kysela , Mark Brown , Ranjani Sridharan , Daniel Baluta , sound-open-firmware@alsa-project.org References: <20210105190808.613050-1-arnd@kernel.org> <59a36212-2412-2dd3-62f2-69c6f65312b1@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 12 Jan 2021 14:17:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Since this is going to be a really invasive change, and past >> experience shows that mucking with Kconfigs will invariably raise a >> number of broken corner cases, if there is support from >> Mark/Takashi/Jaroslav on this idea, we should first test it in the SOF >> tree so that we get a good test coverage and don't break too many eggs >> in Mark's tree. We would also need to concurrently change our CI >> scripts which are dependent on module names. > > I'm in favor of the way Arnd proposed. It's more straightforward and > less code. Thanks Takashi for the feedback. Since yesterday I looked at another problem where we can have unmet dependencies between SoundWire (m) and SOF (y), so we probably need to rethink all this. We had similar issue with SOF and HDaudio before, it's time to revisit all this. > > If you find the number of modules or the too much cutting out being > problematic, you can create a module snd-sof-intel-acpi and > snd-sof-intel-pci containing the driver table entries for all Intel > devices, too. In the case, you'll still need some conditional calls > of intel-dsp-config there, but it's a good step for reducing the > Kconfig complexity. > >> Also maybe in a first pass we can remove the compilation error with >> IS_REACHABLE and in a second pass do more invasive surgery? > > Agreed, we'd like to keep less changes for 5.11 for now. Ack, we'll send smaller changes first.