From: Sodagudi Prasad <psodagud@codeaurora.org>
To: bp@alien8.de, mchehab@kernel.org, linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: EDAC polling
Date: Tue, 11 Sep 2018 06:09:01 -0700 [thread overview]
Message-ID: <ed6869d5d90e03c52ad2b8577f7f5772@codeaurora.org> (raw)
Hi All,
While adding edac_device control info using edac_device_add_device(),
changed the poll_msec at client driver level.
For example -.
https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/edac/qcom_llcc_edac.c?h=msm-4.9#n385
I see that client driver request is not considered and always default
value(1 second) is considered. During the initialization
edac_device_workq_setup sets poll_msed to 1 second.
int edac_device_add_device(struct edac_device_ctl_info *edac_dev)
{
...
...
/* If there IS a check routine, then we are running POLLED */
if (edac_dev->edac_check != NULL) {
/* This instance is NOW RUNNING */
edac_dev->op_state = OP_RUNNING_POLL;
/*
* enable workq processing on this instance,
* default = 1000 msec
*/
edac_device_workq_setup(edac_dev, 1000);
} else {
edac_dev->op_state = OP_RUNNING_INTERRUPT;
}
May I know why client edev_ctl->poll_msec settings is not considered?
-Thanks, Prasad
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
Linux Foundation Collaborative Project
next reply other threads:[~2018-09-11 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 13:09 Sodagudi Prasad [this message]
2018-09-12 8:34 ` EDAC polling Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6869d5d90e03c52ad2b8577f7f5772@codeaurora.org \
--to=psodagud@codeaurora.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).