From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B0FC0044C for ; Wed, 7 Nov 2018 10:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 129312085B for ; Wed, 7 Nov 2018 10:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 129312085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730562AbeKGT7D convert rfc822-to-8bit (ORCPT ); Wed, 7 Nov 2018 14:59:03 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:27686 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbeKGT7C (ORCPT ); Wed, 7 Nov 2018 14:59:02 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by dkim.mimecast.com with ESMTP id uk-mta-179-ZS9EnN-mOoKzVXqdZBIkCg-1; Wed, 07 Nov 2018 10:29:15 +0000 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 7 Nov 2018 10:29:20 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 7 Nov 2018 10:29:20 +0000 From: David Laight To: 'Jarkko Sakkinen' , "x86@kernel.org" , "platform-driver-x86@vger.kernel.org" , "linux-sgx@vger.kernel.org" CC: "dave.hansen@intel.com" , "sean.j.christopherson@intel.com" , "nhorman@redhat.com" , "npmccallum@redhat.com" , "serge.ayoun@intel.com" , "shay.katz-zamir@intel.com" , "haitao.huang@intel.com" , "andriy.shevchenko@linux.intel.com" , "tglx@linutronix.de" , "kai.svahn@intel.com" , Suresh Siddha , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Darren Hart , Andy Shevchenko , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: RE: [PATCH v16 18/22] platform/x86: Intel SGX driver Thread-Topic: [PATCH v16 18/22] platform/x86: Intel SGX driver Thread-Index: AQHUddgrysSRxlXgvUSYD+ItRQz08aVEHTFw Date: Wed, 7 Nov 2018 10:29:20 +0000 Message-ID: References: <20181106134758.10572-1-jarkko.sakkinen@linux.intel.com> <20181106134758.10572-19-jarkko.sakkinen@linux.intel.com> In-Reply-To: <20181106134758.10572-19-jarkko.sakkinen@linux.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: ZS9EnN-mOoKzVXqdZBIkCg-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarkko Sakkinen > Sent: 06 November 2018 13:46 > > Intel Software Guard eXtensions (SGX) is a set of CPU instructions that > can be used by applications to set aside private regions of code and > data. The code outside the enclave is disallowed to access the memory > inside the enclave by the CPU access control. > > SGX driver provides a ioctl API for loading and initializing enclaves. > Address range for enclaves is reserved with mmap() and they are > destroyed with munmap(). Enclave construction, measurement and > initialization is done with the provided the ioctl API. .. > +struct sgx_encl { > + unsigned int flags; > + uint64_t attributes; > + uint64_t xfrm; > + unsigned int page_cnt; > + unsigned int secs_child_cnt; > + struct mutex lock; > + struct mm_struct *mm; > + struct file *backing; > + struct kref refcount; > + unsigned long base; > + unsigned long size; > + unsigned long ssaframesize; > + struct radix_tree_root page_tree; > + struct list_head add_page_reqs; > + struct work_struct add_page_work; > + struct sgx_encl_page secs; > + struct pid *tgid; > + struct mmu_notifier mmu_notifier; > + struct notifier_block pm_notifier; > +}; It may not really matter (yet) but there is at least one hole in that strcture. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)