From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, krzk@kernel.org
Subject: Re: [PATCH v3] media:exynos4-is: Fix a use after free in isp_video_release
Date: Tue, 27 Apr 2021 15:48:15 +0200 [thread overview]
Message-ID: <ed80a3f0-048a-17df-4dff-e9d52b777699@samsung.com> (raw)
In-Reply-To: <20210427132734.5212-1-lyl2019@mail.ustc.edu.cn>
On 27.04.2021 15:27, Lv Yunlong wrote:
> In isp_video_release, file->private_data is freed via
> _vb2_fop_release()->v4l2_fh_release(). But the freed
> file->private_data is still used in v4l2_fh_is_singular_file()
> ->v4l2_fh_is_singular(file->private_data), which is a use
> after free bug.
>
> My patch sets file->private_data to NULL after _vb2_fop_release()
> to avoid the use after free, and uses a variable 'is_singular_file'
> to keep the original function unchanged.
>
> Fixes: 34947b8aebe3f ("[media] exynos4-is: Add the FIMC-IS ISP capture DMA driver")
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Thanks,
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
next prev parent reply other threads:[~2021-04-27 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210427132754eucas1p21042e4e176135e7b3f7b540dc9aadfbb@eucas1p2.samsung.com>
2021-04-27 13:27 ` [PATCH v3] media:exynos4-is: Fix a use after free in isp_video_release Lv Yunlong
2021-04-27 13:48 ` Sylwester Nawrocki [this message]
2021-05-05 9:31 ` Hans Verkuil
2021-05-06 7:19 ` lyl2019
2021-05-06 7:23 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed80a3f0-048a-17df-4dff-e9d52b777699@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).