From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B3DC43143 for ; Tue, 11 Sep 2018 03:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AB33206B7 for ; Tue, 11 Sep 2018 03:46:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FKhb4yaq"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="fbAm4oBe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AB33206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbeIKInf (ORCPT ); Tue, 11 Sep 2018 04:43:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47380 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbeIKInf (ORCPT ); Tue, 11 Sep 2018 04:43:35 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4080E60912; Tue, 11 Sep 2018 03:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1536637580; bh=o6zE83pLUUH56Hk2q/5vC1cMFotLyrG7gFMFLArtHFE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FKhb4yaq4zmJGHYswccdf1gLcaYb7VQcKRIs0MzQTmzwM3JybhsuKssmj6U4im0Q4 xHmUbpb3D6bhcLGszpwM2LNZKRyoZZJWGyhwqT9+KVTSpOLGzZnkjVtb45Wp8Qey3R HN/iqhjiueCHcc03+jWbFyp1qs/4pIkVKfZcAPTo= Received: from [10.204.110.203] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rohitkr@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3775260847; Tue, 11 Sep 2018 03:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1536637579; bh=o6zE83pLUUH56Hk2q/5vC1cMFotLyrG7gFMFLArtHFE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fbAm4oBefFSsPEA5Uo/6g6LZCURQAihEfipVKe8w2ih07WFJrJd5hzVlL0Wn9uVFp GtwdC/o2j0zer0rxIuWY0Ijfm+c8Ar3f3LfIDR3oSJZEHMF9MtL/8uQ6FL1x+sNQd2 nmpDc2EnsQ+CL2FI58soW2sU4XLqtyukQaA4S588= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3775260847 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rohitkr@codeaurora.org Subject: Re: [PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings To: Rob Herring Cc: ohad@wizery.com, bjorn.andersson@linaro.org, mark.rutland@arm.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, srinivas.kandagatla@linaro.org References: <1535975560-8200-1-git-send-email-rohitkr@codeaurora.org> <1535975560-8200-2-git-send-email-rohitkr@codeaurora.org> <20180910200122.GA16410@bogus> From: Rohit Kumar Message-ID: Date: Tue, 11 Sep 2018 09:16:13 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180910200122.GA16410@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Rob for reviewing. On 9/11/2018 1:31 AM, Rob Herring wrote: > On Mon, Sep 03, 2018 at 05:22:39PM +0530, Rohit kumar wrote: >> Add devicetree bindings documentation file for Qualcomm >> Technolgies Inc ADSP Peripheral Image Loader. >> >> Signed-off-by: Rohit kumar >> --- >> .../bindings/remoteproc/qcom,adsp-pil.txt | 123 +++++++++++++++++++++ >> 1 file changed, 123 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt >> new file mode 100644 >> index 0000000..f1c215a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt >> @@ -0,0 +1,123 @@ >> +Qualcomm Technology Inc. ADSP Peripheral Image Loader >> + >> +This document defines the binding for a component that loads and boots firmware >> +on the Qualcomm Technology Inc. ADSP Hexagon core. >> + >> +- compatible: >> + Usage: required >> + Value type: >> + Definition: must be one of: >> + "qcom,sdm845-adsp-pil" >> + >> +- reg: >> + Usage: required >> + Value type: >> + Definition: must specify the base address and size of the qdsp6ss register >> + >> +- interrupts-extended: >> + Usage: required >> + Value type: >> + Definition: must list the watchdog, fatal IRQs ready, handover and >> + stop-ack IRQs >> + >> +- interrupt-names: >> + Usage: required >> + Value type: >> + Definition: must be "wdog", "fatal", "ready", "handover", "stop-ack" >> + >> +- clocks: >> + Usage: required >> + Value type: >> + Definition: List of phandle and clock specifier pairs > How many clocks? > >> + >> +- clock-names: >> + Usage: required >> + Value type: >> + Definition: List of clock input name strings sorted in the same >> + order as the clocks property. > What are the names? I will update these in next spin. >> + >> +- power-domains: >> + Usage: required >> + Value type: >> + Definition: reference to cx power domain node. >> + >> +- resets: >> + Usage: required >> + Value type: >> + Definition: reference to the reset-controller for the lpass > How many? > >> + >> +- reset-names: >> + Usage: required >> + Value type: >> + Definition: must be "pdc_sync" and "cc_lpass" >> + >> +- qcom,halt-regs: >> + Usage: required >> + Value type: >> + Definition: a phandle reference to a syscon representing TCSR followed >> + by the offset within syscon for lpass halt register. >> + >> +- memory-region: >> + Usage: required >> + Value type: >> + Definition: reference to the reserved-memory for the ADSP >> + >> +- qcom,smem-states: >> + Usage: required >> + Value type: >> + Definition: reference to the smem state for requesting the ADSP to >> + shut down >> + >> +- qcom,smem-state-names: >> + Usage: required >> + Value type: >> + Definition: must be "stop" >> + >> + >> += SUBNODES >> +The adsp node may have an subnode named "glink-edge" that describes the >> +communication edge, channels and devices related to the ADSP. >> +See ../soc/qcom/qcom,glink.txt for details on how to describe these. >> + >> += EXAMPLE >> +The following example describes the resources needed to boot control the >> +ADSP, as it is found on SDM845 boards. >> + adsp-pil { >> + compatible = "qcom,sdm845-adsp-pil"; >> + >> + reg = <0x17300000 0x40c>; >> + >> + interrupts-extended = <&intc 0 162 IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "wdog", "fatal", "ready", >> + "handover", "stop-ack"; >> + >> + clocks = <&rpmhcc RPMH_CXO_CLK>, >> + <&gcc GCC_LPASS_SWAY_CLK>, >> + <&lpasscc LPASS_AUDIO_WRAPPER_AON_CLK>, >> + <&lpasscc LPASS_Q6SS_AHBS_AON_CLK>, >> + <&lpasscc LPASS_Q6SS_AHBM_AON_CLK>, >> + <&lpasscc LPASS_QDSP6SS_XO_CLK>, >> + <&lpasscc LPASS_QDSP6SS_SLEEP_CLK>, >> + <&lpasscc LPASS_QDSP6SS_CORE_CLK>; >> + clock-names = "xo", "sway_cbcr", "lpass_aon", >> + "lpass_ahbs_aon_cbcr", >> + "lpass_ahbm_aon_cbcr", "qdsp6ss_xo", >> + "qdsp6ss_sleep", "qdsp6ss_core"; >> + >> + power-domains = <&rpmhpd SDM845_CX>; >> + >> + resets = <&pdc_reset PDC_AUDIO_SYNC_RESET>, >> + <&aoss_reset AOSS_CC_LPASS_RESTART>; >> + reset-names = "pdc_sync", "cc_lpass"; >> + >> + qcom,halt-regs = <&tcsr_mutex_regs 0x22000>; >> + >> + memory-region = <&pil_adsp_mem>; >> + >> + qcom,smem-states = <&adsp_smp2p_out 0>; >> + qcom,smem-state-names = "stop"; >> + }; >> -- >> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., >> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. Thanks, Rohit