From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>, mroos@linux.ee
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
"4 . 14+" <stable@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] cpufreq: longhaul: Set transition_delay_us to 20 ms
Date: Tue, 28 Nov 2017 08:41:30 +0530 [thread overview]
Message-ID: <ed89c17b60d7183144ab4ac4b125fbed373fe670.1511838689.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <alpine.LRH.2.21.1711241741080.10361@math.ut.ee>
The commit e948bc8fbee0 ("cpufreq: Cap the default transition delay
value to 10 ms") caused a regression on EPIA-M min-ITX computer where
shutdown or reboot hangs occasionally with a print message like:
longhaul: Warning: Timeout while waiting for idle PCI bus
cpufreq: __target_index: Failed to change cpu frequency: -16
This probably happens because the cpufreq governor tries to change the
frequency of the CPU faster than allowed by the hardware.
With the above commit, the default transition delay comes to 10 ms for a
transition_latency of 200 us. Set the default transition delay to 20 ms
directly to fix this regression.
Fixes: e948bc8fbee0 ("cpufreq: Cap the default transition delay value to 10 ms")
Cc: 4.14+ <stable@vger.kernel.org> # 4.14+
Reported-by: Meelis Roos <mroos@linux.ee>
Suggested-by: Rafael J. Wysocki <rjw@rjwysocki.net>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/longhaul.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
index c46a12df40dd..56eafcb07859 100644
--- a/drivers/cpufreq/longhaul.c
+++ b/drivers/cpufreq/longhaul.c
@@ -894,7 +894,7 @@ static int longhaul_cpu_init(struct cpufreq_policy *policy)
if ((longhaul_version != TYPE_LONGHAUL_V1) && (scale_voltage != 0))
longhaul_setup_voltagescaling();
- policy->cpuinfo.transition_latency = 200000; /* nsec */
+ policy->transition_delay_us = 20000; /* usec */
return cpufreq_table_validate_and_show(policy, longhaul_table);
}
--
2.15.0.194.g9af6a3dea062
next prev parent reply other threads:[~2017-11-28 3:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 10:53 4.14 regression - hang on shutdown (VIA longhaul related?) Meelis Roos
2017-11-27 13:26 ` Rafael J. Wysocki
2017-11-27 14:31 ` Meelis Roos
2017-11-27 15:19 ` Meelis Roos
2017-11-27 16:21 ` Rafael J. Wysocki
2017-11-27 20:20 ` Meelis Roos
2017-11-28 3:11 ` Viresh Kumar [this message]
2017-11-28 22:07 ` [PATCH] cpufreq: longhaul: Set transition_delay_us to 20 ms Rafael J. Wysocki
2017-11-29 6:59 ` Meelis Roos
2017-12-04 15:03 ` Rafael J. Wysocki
2017-12-05 8:18 ` Meelis Roos
2017-12-05 8:54 ` Meelis Roos
2017-12-05 15:26 ` Rafael J. Wysocki
2017-12-06 18:21 ` Meelis Roos
2017-12-07 4:40 ` Viresh Kumar
2017-12-07 5:14 ` Meelis Roos
2017-12-07 7:26 ` Meelis Roos
2017-12-07 9:33 ` Viresh Kumar
2017-12-07 12:51 ` Meelis Roos
2017-12-07 12:54 ` Rafael J. Wysocki
2017-12-07 9:45 ` [PATCH V2] cpufreq: longhaul: Revert transition_delay_us to 200 ms Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed89c17b60d7183144ab4ac4b125fbed373fe670.1511838689.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).