From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbdGAJJd (ORCPT ); Sat, 1 Jul 2017 05:09:33 -0400 Received: from mleia.com ([178.79.152.223]:48216 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdGAJJc (ORCPT ); Sat, 1 Jul 2017 05:09:32 -0400 X-Greylist: delayed 562 seconds by postgrey-1.27 at vger.kernel.org; Sat, 01 Jul 2017 05:09:31 EDT Subject: Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure To: "Gustavo A. R. Silva" , Bartlomiej Zolnierkiewicz , Tejun Heo References: <20170630213056.GA12695@embeddedgus> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Vladimir Zapolskiy Message-ID: Date: Sat, 1 Jul 2017 12:00:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170630213056.GA12695@embeddedgus> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20170701_100008_276384_E60AA132 X-CRM114-Status: GOOD ( 18.06 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Gustavo, On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: > Print error message on platform_get_irq failure before return. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Print the return value of platform_get_irq on failure. > > drivers/ata/pata_imx.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c > index d4caa23..66fb1ab 100644 > --- a/drivers/ata/pata_imx.c > +++ b/drivers/ata/pata_imx.c > @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev) > int ret; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) > + if (irq < 0) { > + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq); > return irq; > - > + } > priv = devm_kzalloc(&pdev->dev, > sizeof(struct pata_imx_priv), GFP_KERNEL); > if (!priv) > this patch is wrong, I've explained why at https://lkml.org/lkml/2017/6/30/144 Please handle -EPROBE_DEFER case, when your change adds the second (redundant) error level message printed to the kernel log. -- With best wishes, Vladimir