From: Neil Armstrong <narmstrong@baylibre.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
airlied@linux.ie, carlo@caione.org, khilman@baylibre.com
Cc: dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] drm/meson: Fix some error handling paths in 'meson_drv_bind_master()'
Date: Tue, 13 Mar 2018 10:36:03 +0100 [thread overview]
Message-ID: <ed8b162c-ac19-bdbb-4da9-e891a4855d2d@baylibre.com> (raw)
In-Reply-To: <df47e03d36c2cf7bc37ec3105fc47c16555bd946.1520885192.git.christophe.jaillet@wanadoo.fr>
On 12/03/2018 21:15, Christophe JAILLET wrote:
> If one of these functions fail, we whould free 'drm', as alreadry done in
> the other error handling paths, below and above.
>
> Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index 6ee3dd7fa450..3baceb744beb 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -189,35 +189,43 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "vpu");
> regs = devm_ioremap_resource(dev, res);
> - if (IS_ERR(regs))
> - return PTR_ERR(regs);
> + if (IS_ERR(regs)) {
> + ret = PTR_ERR(regs);
> + goto free_drm;
> + }
>
> priv->io_base = regs;
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hhi");
> /* Simply ioremap since it may be a shared register zone */
> regs = devm_ioremap(dev, res->start, resource_size(res));
> - if (!regs)
> - return -EADDRNOTAVAIL;
> + if (!regs) {
> + ret = -EADDRNOTAVAIL;
> + goto free_drm;
> + }
>
> priv->hhi = devm_regmap_init_mmio(dev, regs,
> &meson_regmap_config);
> if (IS_ERR(priv->hhi)) {
> dev_err(&pdev->dev, "Couldn't create the HHI regmap\n");
> - return PTR_ERR(priv->hhi);
> + ret = PTR_ERR(priv->hhi);
> + goto free_drm;
> }
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dmc");
> /* Simply ioremap since it may be a shared register zone */
> regs = devm_ioremap(dev, res->start, resource_size(res));
> - if (!regs)
> - return -EADDRNOTAVAIL;
> + if (!regs) {
> + ret = -EADDRNOTAVAIL;
> + goto free_drm;
> + }
>
> priv->dmc = devm_regmap_init_mmio(dev, regs,
> &meson_regmap_config);
> if (IS_ERR(priv->dmc)) {
> dev_err(&pdev->dev, "Couldn't create the DMC regmap\n");
> - return PTR_ERR(priv->dmc);
> + ret = PTR_ERR(priv->dmc);
> + goto free_drm;
> }
>
> priv->vsync_irq = platform_get_irq(pdev, 0);
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Thanks,
Neil
next prev parent reply other threads:[~2018-03-13 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 20:15 [PATCH 0/3] Fix some error handling paths in 'meson_drv_bind_master()' Christophe JAILLET
2018-03-12 20:15 ` [PATCH 1/3] drm/meson: Fix an un-handled error path " Christophe JAILLET
2018-03-13 9:36 ` Neil Armstrong
2018-03-12 20:15 ` [PATCH 2/3] drm/meson: Use drm_dev_put() instead of drm_dev_unref() Christophe JAILLET
2018-03-13 9:34 ` Neil Armstrong
2018-03-12 20:15 ` [PATCH 3/3] drm/meson: Fix some error handling paths in 'meson_drv_bind_master()' Christophe JAILLET
2018-03-13 9:36 ` Neil Armstrong [this message]
2018-03-13 9:40 ` [PATCH 0/3] " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed8b162c-ac19-bdbb-4da9-e891a4855d2d@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=airlied@linux.ie \
--cc=carlo@caione.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).