From: Lukasz Luba <l.luba@partner.samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: b.zolnierkie@samsung.com, krzk@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, kyungmin.park@samsung.com,
m.szyprowski@samsung.com, s.nawrocki@samsung.com,
myungjoo.ham@samsung.com, kgene@kernel.org
Subject: Re: [PATCH 1/3] include: dt-bindings: add Performance Monitoring Unit for Exynos
Date: Wed, 17 Apr 2019 12:50:57 +0200 [thread overview]
Message-ID: <ed9df324-33ef-2e58-8b77-9a2561a4d6a4@partner.samsung.com> (raw)
In-Reply-To: <3fcb6dde-7ccc-4da6-5f8b-c8338edaa155@samsung.com>
Hi Chanwoo,
On 4/17/19 10:10 AM, Chanwoo Choi wrote:
> Hi Lukasz,
>
> On 19. 4. 17. 오후 4:48, Lukasz Luba wrote:
>> This patch add support of a new feature which can be used in DT:
>> Performance Monitoring Unit with defined event data type.
>> In this patch the event data types are defined for Exynos PPMU.
>> The patch also updates the MAINTAINERS file accordingly.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>> MAINTAINERS | 5 +++++
>> include/dt-bindings/pmu/exynos_ppmu.h | 24 ++++++++++++++++++++++++
>> 2 files changed, 29 insertions(+)
>> create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3671fde..f4aac78 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -12376,6 +12376,11 @@ L: linux-scsi@vger.kernel.org
>> S: Supported
>> F: drivers/scsi/pm8001/
>>
>> +PMU EXYNOS DT BINDINGS
>> +M: Lukasz Luba <l.luba@partner.samsung.com>
>> +S: Maintained
>> +F: include/dt-bindings/pmu/exynos_ppmu.h
>> +
>
> IMHO, I'm not sure that it is right of adding one dt-binding header file
> to MAINTAINERS file. If right, I'm OK.
>
>
>> PNP SUPPORT
>> M: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>> S: Maintained
>> diff --git a/include/dt-bindings/pmu/exynos_ppmu.h b/include/dt-bindings/pmu/exynos_ppmu.h
>> new file mode 100644
>> index 0000000..a6971eb
>> --- /dev/null
>> +++ b/include/dt-bindings/pmu/exynos_ppmu.h
>> @@ -0,0 +1,24 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Samsung Exynos PPMU event types for counting in regs
>> + *
>> + * Copyright (c) 2019, Samsung
>> + * Author: Lukasz Luba <l.luba@partner.samsung.com>
>> + */
>> +
>> +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H
>> +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H
>> +
>> +
>> +#define PPMU_RO_BUSY_CYCLE_CNT 0x0
>> +#define PPMU_WO_BUSY_CYCLE_CNT 0x1
>> +#define PPMU_RW_BUSY_CYCLE_CNT 0x2
>> +#define PPMU_RO_REQUEST_CNT 0x3
>> +#define PPMU_WO_REQUEST_CNT 0x4
>> +#define PPMU_RO_DATA_CNT 0x5
>> +#define PPMU_WO_DATA_CNT 0x6
>> +#define PPMU_RO_LATENCY 0x12
>> +#define PPMU_WO_LATENCY 0x16
>> +#define PPMU_V2_EVT3_RW_DATA_CNT 0x22
>
> If we can select the data type for monitoring, it looks good to me.
> But, when I developed the Exynos PPMU, I has not tested other data type
> except for PPMU_RO_DATA_CNT and PPMU_WO_DATA_CNT.
>
> Do you test all data types with PPMU device?
Yes, I have tested all - 1 of them on Odroid XU4 with memory controller
and they work. I haven't checked the last option for Exynos5433,
but it should work since it was default option in your driver.
Regards,
Lukasz
>
>> +
>> +#endif
>>
>
>
next prev parent reply other threads:[~2019-04-17 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190417074829eucas1p234e664f9bf295eca8d2fad6ba953f37c@eucas1p2.samsung.com>
2019-04-17 7:48 ` [PATCH 0/3] Exynos Performance Monitoring Counters enhancements Lukasz Luba
[not found] ` <CGME20190417074832eucas1p26eca3ed8bf754787b4860206ba542e1c@eucas1p2.samsung.com>
2019-04-17 7:48 ` [PATCH 1/3] include: dt-bindings: add Performance Monitoring Unit for Exynos Lukasz Luba
2019-04-17 8:10 ` Chanwoo Choi
2019-04-17 10:50 ` Lukasz Luba [this message]
[not found] ` <CGME20190417074834eucas1p1faa327cb6394d899a8e107ba61f28fda@eucas1p1.samsung.com>
2019-04-17 7:48 ` [PATCH 2/3] drivers: devfreq: events: extend events by type of counted data Lukasz Luba
2019-04-17 8:22 ` Chanwoo Choi
2019-04-17 11:00 ` Lukasz Luba
[not found] ` <CGME20190417074835eucas1p19319bedd176d55e10b272881b7c68919@eucas1p1.samsung.com>
2019-04-17 7:48 ` [PATCH 3/3] Documentation: devicetree: add PPMU events description Lukasz Luba
2019-04-17 8:26 ` Chanwoo Choi
2019-04-18 9:50 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9df324-33ef-2e58-8b77-9a2561a4d6a4@partner.samsung.com \
--to=l.luba@partner.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).