From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939281AbdDSUWL (ORCPT ); Wed, 19 Apr 2017 16:22:11 -0400 Received: from resqmta-po-04v.sys.comcast.net ([96.114.154.163]:42874 "EHLO resqmta-po-04v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936913AbdDSUWJ (ORCPT ); Wed, 19 Apr 2017 16:22:09 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 References: <20170322180458.15567-1-fathi.boudra@linaro.org> To: Fathi Boudra Cc: "linux-kernel@vger.kernel.org" , Pratyush Anand , linux-kselftest@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: Date: Wed, 19 Apr 2017 14:22:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfG3xyBWTBkqm7vONKJg3OH5pW8x+aEJjUuoLTEMbD8Za2vfRUQ8aCruGbeRIczkfJMj9CBAj6/KGl6D77i9tkk/hf9LpiFzd6dv+nSQ3kEDH26OaOW5q +wSkXOENufPXVpTdI3SWf9SMMOM0rriGvJg9rBcvRxrXJe1rzs350xZkF3+/Z/KbxaCxQtrudJC908BpdQipb1arOZtmaeEY6mv3ng6I3J/YZvAjspf6CxCL /XPatMqO3oiWD3QdEIvm7dwnMU2Qoy7tEg7AV4WCtuAWc7DMcRpONYfp9Lb+WPVsR0GlIX8E9ko9DRqXr3+OuQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2017 11:31 AM, Fathi Boudra wrote: > gentle ping > > On 22 March 2017 at 20:04, Fathi Boudra wrote: >> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". >> It covers only the native build because it's computed from uname -m output. >> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile >> the test. >> Fix the test to allow both native and cross-compilation of the test. >> >> Note: glibc is missing several of the TRAP_* constants in the userspace >> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. >> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 >> >> Signed-off-by: Fathi Boudra I plan to get to it towards the end of this week. Thanks for the ping. -- Shuah >> --- >> tools/testing/selftests/breakpoints/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile >> index 72aa103e4141..6b214b7b10fb 100644 >> --- a/tools/testing/selftests/breakpoints/Makefile >> +++ b/tools/testing/selftests/breakpoints/Makefile >> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) >> ifeq ($(ARCH),x86) >> TEST_GEN_PROGS := breakpoint_test >> endif >> -ifeq ($(ARCH),aarch64) >> +ifneq (,$(filter $(ARCH),aarch64 arm64)) >> TEST_GEN_PROGS := breakpoint_test_arm64 >> endif >> >> -- >> 2.11.0 >> > >