On 08/08/2018 05:37 AM, mpe@ellerman.id.au wrote: > Thomas Richter writes: >> Add support for s390 auxiliary trace support. >> Use 'perf record -e rbd000' to create the perf.data file. >> The event also has the symbolic name SF_CYCLES_BASIC_DIAG, >> using 'perf record -e SF_CYCLES_BASIC_DIAG' is equivalent. > ... >> >> Signed-off-by: Thomas Richter >> Reviewed-by: Hendrik Brueckner >> --- >> tools/perf/util/s390-cpumsf-kernel.h | 71 ++++++++ >> tools/perf/util/s390-cpumsf.c | 244 ++++++++++++++++++++++++++- >> 2 files changed, 314 insertions(+), 1 deletion(-) >> create mode 100644 tools/perf/util/s390-cpumsf-kernel.h > > > I'm seeing a build break on ppc64le which seems to be caused by this > commit (I haven't bisected): > > util/s390-cpumsf.c: In function ‘trailer_timestamp’: > util/s390-cpumsf.c:222:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] > return *((unsigned long long *) &te->timestamp[te->t]); > ^ > > > And on powerpc big endian: > In file included from util/cpumap.h:10:0, > from util/s390-cpumsf.c:150: > util/s390-cpumsf.c: In function ‘s390_cpumsf_basic_show’: > util/s390-cpumsf.c:187:10: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘size_t {aka unsigned int}’ [-Werror=format=] > pr_err("Invalid AUX trace basic entry [%#08lx]\n", pos); > ^ > > cheers > Can you please try this patch. Thanks a lot -- Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294