From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Sylwester Nawrocki <snawrocki@kernel.org>,
Jaewon Kim <jaewon02.kim@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
David Virag <virag.david003@gmail.com>,
Youngmin Nam <youngmin.nam@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Palmer <daniel@0x0f.com>, Hao Fang <fanghao11@huawei.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks
Date: Tue, 21 Dec 2021 09:19:45 +0100 [thread overview]
Message-ID: <edd828b4-66ad-1c1e-4332-e1b05931e92a@canonical.com> (raw)
In-Reply-To: <CAPLW+4msw_yeG4uDbS9mMULOuc43MK9O6Paya_Z2jBj2t6ZTiA@mail.gmail.com>
On 20/12/2021 15:55, Sam Protsenko wrote:
> On Mon, 20 Dec 2021 at 11:31, Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> On 19/12/2021 23:29, Sylwester Nawrocki wrote:
>>> On 17.12.2021 17:15, Sam Protsenko wrote:
>>>> System Register is used to configure system behavior, like USI protocol,
>>>> etc. SYSREG clocks should be provided to corresponding syscon nodes, to
>>>> make it possible to modify SYSREG registers.
>>>>
>>>> While at it, add also missing PMU and GPIO clocks, which looks necessary
>>>> and might be needed for corresponding Exynos850 features soon.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@canonical.com>
>>>> Acked-by: Rob Herring<robh@kernel.org>
>>>> Acked-by: Chanwoo Choi<cw00.choi@samsung.com>
>>>> Signed-off-by: Sam Protsenko<semen.protsenko@linaro.org>
>>>
>>> Apologies for late reply, this patch is applied now.
>>>
>>
>> Sam,
>>
>> The clock is used in the DTSI, so since this was applied, there are only
>> two choices now:
>> 1. wait for next cycle with DTSI and DTS,
>> 2. Resubmit with replacing the newly added clocks in DTSI/DTS with
>> numbers and a TODO note.
>>
>
> But why? I thought because Sylwester applied my clock patches, those
> will get into v5.17, and so DTSI/DTS might rely on those clocks? If I
> get it wrong, please let me know why, and I'll go with item (2) you
> suggested.
If I apply the DTSI+DTS, all my builds will start failing. The
linux-next (since Sylwester's tree is included) should build fine, but
my tree won't be buildable anymore. Then arm-soc pulls my tree and gets
said because it does not build. Later, Linus will be unhappy if he pulls
arm-soc (thus mine) before clock tree.
Other solution, instead of using raw numbers, is to copy-paste the clock
macros you use directly in DTSI and do not include the clock header.
This actually might be cleaner choice - changes will be limited to one
place in DTSI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-12-21 8:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 16:15 [PATCH v4 0/7] arm64: dts: exynos: Add E850-96 board support Sam Protsenko
2021-12-17 16:15 ` [PATCH v4 1/7] dt-bindings: clock: exynos850: Add bindings for Exynos850 sysreg clocks Sam Protsenko
2021-12-19 22:29 ` Sylwester Nawrocki
2021-12-20 9:31 ` Krzysztof Kozlowski
2021-12-20 14:55 ` Sam Protsenko
2021-12-21 8:19 ` Krzysztof Kozlowski [this message]
2021-12-21 8:20 ` Krzysztof Kozlowski
2021-12-21 12:09 ` Sam Protsenko
2021-12-17 16:15 ` [PATCH v4 2/7] clk: samsung: exynos850: Add missing " Sam Protsenko
2021-12-19 22:31 ` Sylwester Nawrocki
2021-12-17 16:15 ` [PATCH v4 3/7] dt-bindings: Add vendor prefix for WinLink Sam Protsenko
2021-12-20 9:36 ` Krzysztof Kozlowski
2021-12-20 15:05 ` Sam Protsenko
2021-12-20 9:37 ` (subset) " Krzysztof Kozlowski
2021-12-17 16:15 ` [PATCH v4 4/7] dt-bindings: arm: samsung: Document E850-96 board binding Sam Protsenko
2021-12-20 9:37 ` (subset) " Krzysztof Kozlowski
2021-12-17 16:15 ` [PATCH v4 5/7] dt-bindings: pinctrl: samsung: Add pin drive definitions for Exynos850 Sam Protsenko
2021-12-20 9:37 ` (subset) " Krzysztof Kozlowski
2021-12-17 16:15 ` [PATCH v4 6/7] arm64: dts: exynos: Add initial Exynos850 SoC support Sam Protsenko
2021-12-17 16:15 ` [PATCH v4 7/7] arm64: dts: exynos: Add initial E850-96 board support Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edd828b4-66ad-1c1e-4332-e1b05931e92a@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=fanghao11@huawei.com \
--cc=jaewon02.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=snawrocki@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=virag.david003@gmail.com \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).