From: "Murilo Opsfelder Araújo" <mopsfelder@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
Michael Ellerman <mpe@ellerman.id.au>,
kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Alex Williamson <alex.williamson@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH
Date: Thu, 8 Jun 2017 12:32:54 -0300 [thread overview]
Message-ID: <edf52bc1-977d-27bc-de8d-a5721e1c3f59@gmail.com> (raw)
In-Reply-To: <dc26bfd2-9ba6-b3bd-afa9-ed0d801757b7@ozlabs.ru>
On 06/08/2017 10:10 AM, Alexey Kardashevskiy wrote:
[...]
> The config you attached in the first mail has CONFIG_VFIO_SPAPR_EEH=m, here
> is my confusion. The config from the link below does not have KVM_BOOK3S_64
> which selects SPAPR_TCE_IOMMU and which in turn selects VFIO_IOMMU_SPAPR_TCE.
>
> So
> https://github.com/0day-ci/linux/commit/36ed1ddb05e132aa3cfbb610f0f8402a0774da12
> looks correct.
It wasn't me that attached the .config.gz, it was this 0dayci robot.
When CONFIG_VFIO_SPAPR_EEH=m, there is no definition of it in autoconf.h, only
CONFIG_VFIO_SPAPR_EEH_MODULE is defined:
$ grep 'VFIO_SPAPR_EEH' ./include/generated/autoconf.h
#define CONFIG_VFIO_SPAPR_EEH_MODULE 1
In this case, `#ifdef CONFIG_VFIO_SPAPR_EEH` will be false. That's why my v1
patch failed with the 0dayci .config and robot reported back.
This was addressed in my v2 patch using the IS_ENABLED() macro, which checks for
both CONFIG_<name> and CONFIG_<name>_MODULE definitions.
--
Murilo
next prev parent reply other threads:[~2017-06-08 15:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 12:09 [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH Murilo Opsfelder Araujo
2017-06-07 10:49 ` Michael Ellerman
2017-06-07 16:31 ` kbuild test robot
2017-06-08 5:35 ` Alexey Kardashevskiy
2017-06-08 5:36 ` Alexey Kardashevskiy
2017-06-13 8:36 ` [kbuild-all] " Ye Xiaolong
2017-06-08 11:41 ` Michael Ellerman
2017-06-08 12:45 ` Murilo Opsfelder Araújo
2017-06-08 13:10 ` Alexey Kardashevskiy
2017-06-08 15:32 ` Murilo Opsfelder Araújo [this message]
2017-06-08 0:06 ` [PATCH v2] " Murilo Opsfelder Araujo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edf52bc1-977d-27bc-de8d-a5721e1c3f59@gmail.com \
--to=mopsfelder@gmail.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=kbuild-all@01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).