LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Filipe Manana <fdmanana@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Josef Bacik <josef@toxicpanda.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
	David Sterba <dsterba@suse.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 5.6-rc2
Date: Mon, 17 Feb 2020 16:04:53 +0000
Message-ID: <ee0fa89a-a138-efea-7c04-799bbd9ba17c@suse.com> (raw)
In-Reply-To: <CAHk-=wiG+wjLjuDDNiqfL3iLW25yqsMK_gNEWomyMH=8kxOLwQ@mail.gmail.com>



On 17/02/20 05:08, Linus Torvalds wrote:
> On Sun, Feb 16, 2020 at 7:02 PM Josef Bacik <josef@toxicpanda.com> wrote:
>>
>> I assume Filipe wrote this based on my patch here
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git/commit/?id=c821555d2b9733d8f483c9e79481c7209e1c1fb0
>>
>> which makes it so we can allocate safely in this context, but that patch hasn't
>> made it's way to you yet.  Do you want it now?  It was prep for a much less safe
>> patchset, but is fine by itself.  Thanks,
> 
> I assume it's either that, or revert 28553fa992cb and do it differently..
> 
> I'll leave that whole decision to the btrfs people who actually know
> the code and the situations and what the alternative would look
> like...

So what happened was that the patch was developed against the
integration branch, where we don't use search paths in spinning mode
anymore - this was done by Josef's patch, which itself is not a bug fix
but it's necessary for another bug fix that is only on the integration
branch.

On 5.6-rcX and any other other older kernels we have the search using
spinning locks, that's why we run into this problem.

The solution can be either adding Josef's patch or changing the order in
which my patch unlocks the file range - to do it after the patch is
freed (which releases any spin locks it might be holding).

I've just sent a patch for that:
https://patchwork.kernel.org/patch/11386723/

I'm fine with either solution.

Thanks.

> 
>                Linus
> 

  parent reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-16 21:32 Linus Torvalds
2020-02-17  2:08 ` Dave Jones
2020-02-17  2:24   ` Linus Torvalds
2020-02-17  3:02     ` Josef Bacik
2020-02-17  5:08       ` Linus Torvalds
2020-02-17 12:30         ` David Sterba
2020-02-17 16:45           ` Dave Jones
2020-02-17 16:04         ` Filipe Manana [this message]
2020-02-17 16:21 ` Chris Wilson
2020-02-17 21:20   ` Linus Torvalds
2020-02-17 21:29     ` Chris Wilson
2020-02-20 22:41       ` Rafael J. Wysocki
2020-02-21  0:46         ` Rafael J. Wysocki
2020-02-21  9:19           ` Chris Wilson
     [not found]             ` <CAJZ5v0h07em8y5bXcnUTBcjie8pCttADK9QX9W_cB0WQRcDfGQ@mail.gmail.com>
2020-02-21 18:02               ` Linus Torvalds
2020-02-23 23:57                 ` Rafael J. Wysocki
2020-02-17 18:42 ` sinisa
2020-02-17 20:17   ` Dominik Brodowski
2020-02-21  1:38   ` Dave Airlie
2020-02-21  2:23     ` [Intel-gfx] " Souza, Jose
2020-02-24 18:24       ` Siniša Bandin
2020-03-02 16:39       ` Siniša Bandin
2020-03-02 17:04         ` Jani Nikula
2020-03-03  7:08           ` Sinisa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee0fa89a-a138-efea-7c04-799bbd9ba17c@suse.com \
    --to=fdmanana@suse.com \
    --cc=davej@codemonkey.org.uk \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git